Skip to content

Conversation

zdevito
Copy link
Contributor

@zdevito zdevito commented Aug 14, 2023

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 14, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107171

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d4d73e6 with merge base 2e73c86 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zdevito added a commit that referenced this pull request Aug 14, 2023
ghstack-source-id: 77562fb
Pull Request resolved: #107171
@zdevito zdevito requested a review from ngimel August 14, 2023 22:02
@zdevito zdevito added the topic: not user facing topic category label Aug 18, 2023
@zdevito
Copy link
Contributor Author

zdevito commented Aug 18, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 18, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

pytorchmergebot pushed a commit that referenced this pull request Aug 23, 2023
This change is to match the behavior of _record_memory_history which was
recently changed to enable history recording on all devices rather than
the current one. It prevents confusing situations where the observer
was registered before the device was set for the training run.

It also ensures the allocators have been initialized in the python binding just in case this is the first call to the CUDA API.
Fixes #107330
Pull Request resolved: #107399
Approved by: https://github.com/eellison
ghstack dependencies: #107171
pytorchmergebot pushed a commit that referenced this pull request Aug 24, 2023
Pull Request resolved: #107660
Approved by: https://github.com/albanD
ghstack dependencies: #107171, #107399
@facebook-github-bot facebook-github-bot deleted the gh/zdevito/248/head branch August 27, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged merging topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants