Skip to content

Conversation

leslie-fang-intel
Copy link
Collaborator

@leslie-fang-intel leslie-fang-intel commented Aug 17, 2023

Stack from ghstack (oldest at bottom):

Summary
Fix the #100565 by allowing float32 data type when Autocast CPU is disabled. Current behavior is:

  • When autocast is disabled and user passes in float data type, it works well.
  • When autocast is enabled and user passes in float data type, a warn message throws UserWarning: In CPU autocast, but the target dtype is not supported. Disabling autocast. to disable autocast automatically

TestPlan

python -u -m pytest -s -v test_autocast.py -k test_autocast_disabled_with_fp32_dtype

cc @mcarilli @ptrblck @jgong5

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 17, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107348

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 70cc655 with merge base 4979a1b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

leslie-fang-intel added a commit that referenced this pull request Aug 17, 2023
ghstack-source-id: 7d106a3
Pull Request resolved: #107348
@leslie-fang-intel leslie-fang-intel added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 17, 2023
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@leslie-fang-intel
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@leslie-fang-intel
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ksmdnl
Copy link

ksmdnl commented Oct 24, 2023

Hi all, is this already in the stable version or when will this fix be included there?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants