[pytorch][fakepg] enhance fakepg: broadcast and scatter #107480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add support for broadcast and scatter in FakeProcessGroup. As a side note, we can't easily support broadcast_object_list or scatter_object_list since they rely on actual broadcasted/scattered values for pickle object deserialization. We could add support for rank 0, but other to support ranks may need additional changes outside of FakeProcessGroup. Test Plan: `buck2 run mode/dev-nosan -c fbcode.enable_gpu_sections=true //caffe2/test/distributed:fake_pg`, on of TARGETS diff: D48481513 `python test/distributed/test_fake_pg.py` after github sync Differential Revision: D48481512 fbshipit-source-id: 96c9c0db6d900593269ff55fe90307b7bdd75b2a
xmfan
requested review from
H-Huang,
awgu,
fduwjj,
fegin,
kwen2501,
mrshenli,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107480
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 9da551b with merge base bdecdfd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D48481512 |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
to wenzhe-nrv/pytorch
that referenced
this pull request
Aug 19, 2023
Summary: Add support for broadcast and scatter in FakeProcessGroup. As a side note, we can't easily support broadcast_object_list or scatter_object_list since they rely on actual broadcasted/scattered values for pickle object deserialization. We could add support for rank 0, but other to support ranks may need additional changes outside of FakeProcessGroup. Test Plan: `buck2 run mode/dev-nosan -c fbcode.enable_gpu_sections=true //caffe2/test/distributed:fake_pg`, on of TARGETS diff: D48481513 `python test/distributed/test_fake_pg.py` after github sync Differential Revision: D48481512 Pull Request resolved: pytorch#107480 Approved by: https://github.com/wanchaol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add support for broadcast and scatter in FakeProcessGroup.
As a side note, we can't easily support broadcast_object_list or
scatter_object_list since they rely on actual broadcasted/scattered
values for pickle object deserialization. We could add support for rank 0, but
other to support ranks may need additional changes outside of
FakeProcessGroup.
Test Plan:
buck2 run mode/dev-nosan -c fbcode.enable_gpu_sections=true //caffe2/test/distributed:fake_pg, on of TARGETS diff: D48481513python test/distributed/test_fake_pg.pyafter github syncDifferential Revision: D48481512