[inductor] visualize fused ops in svg graph #107752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

weifengpy wants to merge 20 commits into gh/weifengpy/2/base from gh/weifengpy/2/head

Contributor

weifengpy commented Aug 22, 2023 •

edited

Loading

Stack from ghstack (oldest at bottom):

-> [inductor] visualize fused ops in svg graph #107752

example usage

TORCH_COMPILE_DEBUG=1 INDUCTOR_ORIG_FX_SVG=1 INDUCTOR_POST_FUSION_SVG=1 python trig.py: show original fx node name, file, and code. see snapshot 2 where we have origin_0, 1, 2
trig.py can be found in P816304818

Implementation

keep original fx graph in GraphLowering, self.orig_gm: torch.fx.GraphModule = gm.__copy__()
draw original fx graph with origins ir_post_fusion V.debug.draw_orig_fx_graph(self.orig_gm, self.scheduler.nodes). node.meta["buff_meta"] tracks buf_name

Screenshot 2023-08-29 at 12 40 24 PM

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov


          [in progress][inductor] visualize fused ops in svg graph

422ebbb

[ghstack-poisoned]

pytorch-bot bot added the release notes: fx label

pytorch-bot bot commented Aug 22, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107752

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 42bd4ec with merge base 40b2c79 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

weifengpy added a commit that referenced this pull request


          [in progress][inductor] visualize fused ops in svg graph

51d2aae

ghstack-source-id: d18edbd
Pull Request resolved: #107752

weifengpy marked this pull request as draft

August 22, 2023 23:32


          Update on "[in progress][inductor] visualize fused ops in svg graph"

0dfed41

[ghstack-poisoned]


          Update on "[in progress][inductor] visualize fused ops in svg graph"

6b7586a

[ghstack-poisoned]

github-actions bot added module: inductor ciflow/inductor labels


          Update on "[in progress][inductor] visualize fused ops in svg graph"

406d71b

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

weifengpy added a commit that referenced this pull request


          [in progress][inductor] visualize fused ops in svg graph

18cfe5d

ghstack-source-id: 6f5d9de
Pull Request resolved: #107752


          Update on "[in progress][inductor] visualize fused ops in svg graph"

75fe7f7

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

weifengpy added a commit that referenced this pull request


          [in progress][inductor] visualize fused ops in svg graph

7e223bf

ghstack-source-id: 59ec723
Pull Request resolved: #107752


          Update on "[in progress][inductor] visualize fused ops in svg graph"

b8bcf50

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

weifengpy added a commit that referenced this pull request


          [in progress][inductor] visualize fused ops in svg graph

428c88b

ghstack-source-id: 5f6116c
Pull Request resolved: #107752


          Update on "[in progress][inductor] visualize fused ops in svg graph"

fe05679

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]


          Update on "[in progress][inductor] visualize fused ops in svg graph"

85fa2c6

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]


          Update on "[in progress][inductor] visualize fused ops in svg graph"

cf33c8e

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]


          Update on "[in progress][inductor] visualize fused ops in svg graph"

48bbe74

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

weifengpy added a commit that referenced this pull request


          [in progress][inductor] visualize fused ops in svg graph

fdfedde

ghstack-source-id: 263809e
Pull Request resolved: #107752


          Update on "[in progress][inductor] visualize fused ops in svg graph"

29dbe53

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]


          Update on "[in progress][inductor] visualize fused ops in svg graph"

963f352

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]


          Update on "[in progress][inductor] visualize fused ops in svg graph"

6a8074d

This PR does 2 thing
* `TORCH_COMPILE_DEBUG=1 INDUCTOR_ORIG_FX_SVG=1 python bert.py`: create a new .svg to visualize original FX Graph that shows which nodes will be fused in ir_post_fusion. see snapshot 1 where 3 nodes are marked with boxes
* `TORCH_COMPILE_DEBUG=1 INDUCTOR_POST_FUSION_SVG=1 python bert.py`: show original fx node name, file, and code. see snapshot 2 where we have origin_0, 1, 2

Implementation
* keep original fx graph in GraphLowering, ```self.orig_gm: torch.fx.GraphModule = gm.__copy__()```
* draw original fx graph with origins ir_post_fusion ```V.debug.draw_orig_fx_graph(self.orig_gm, self.scheduler.nodes)```. node.meta["buff_meta"] tracks buf_name 

 
<img width="350" alt="Screenshot 2023-08-29 at 12 40 24 PM" src="https://github.com/pytorch/pytorch/assets/134637289/c4e197cb-ab3b-4a09-a584-c1356376accb">
<img width="300" alt="Screenshot 2023-08-29 at 12 42 06 PM" src="https://github.com/pytorch/pytorch/assets/134637289/1f90b82d-2efa-4830-a8dd-1fed958e46ec">




cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]


          Update on "[in progress][inductor] visualize fused ops in svg graph"

54a396c

This PR does 2 thing
* `TORCH_COMPILE_DEBUG=1 INDUCTOR_ORIG_FX_SVG=1 python trig.py`: create a new .svg to visualize original FX Graph that shows which nodes will be fused in ir_post_fusion. see snapshot 1 where 3 nodes are marked with boxes
* `TORCH_COMPILE_DEBUG=1 INDUCTOR_POST_FUSION_SVG=1 python trig.py`: show original fx node name, file, and code. see snapshot 2 where we have origin_0, 1, 2
* trig.py can be found in P816304818

Implementation
* keep original fx graph in GraphLowering, ```self.orig_gm: torch.fx.GraphModule = gm.__copy__()```
* draw original fx graph with origins ir_post_fusion ```V.debug.draw_orig_fx_graph(self.orig_gm, self.scheduler.nodes)```. node.meta["buff_meta"] tracks buf_name 

 
<img width="350" alt="Screenshot 2023-08-29 at 12 40 24 PM" src="https://github.com/pytorch/pytorch/assets/134637289/c4e197cb-ab3b-4a09-a584-c1356376accb">
<img width="300" alt="Screenshot 2023-08-29 at 12 42 06 PM" src="https://github.com/pytorch/pytorch/assets/134637289/1f90b82d-2efa-4830-a8dd-1fed958e46ec">




cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

weifengpy added a commit that referenced this pull request


          [in progress][inductor] visualize fused ops in svg graph

33b3898

ghstack-source-id: a889438
Pull Request resolved: #107752

weifengpy added the ciflow/trunk label

weifengpy marked this pull request as ready for review

August 30, 2023 15:16

weifengpy changed the title ~~[in progress][inductor] visualize fused ops in svg graph~~ [inductor] visualize fused ops in svg graph


          Update on "[inductor] visualize fused ops in svg graph"

da96c12

This PR does 2 thing
* `TORCH_COMPILE_DEBUG=1 INDUCTOR_ORIG_FX_SVG=1 python trig.py`: create a new .svg to visualize original FX Graph that shows which nodes will be fused in ir_post_fusion. see snapshot 1 where 3 nodes are marked with boxes
* `TORCH_COMPILE_DEBUG=1 INDUCTOR_POST_FUSION_SVG=1 python trig.py`: show original fx node name, file, and code. see snapshot 2 where we have origin_0, 1, 2
* trig.py can be found in P816304818

Implementation
* keep original fx graph in GraphLowering, ```self.orig_gm: torch.fx.GraphModule = gm.__copy__()```
* draw original fx graph with origins ir_post_fusion ```V.debug.draw_orig_fx_graph(self.orig_gm, self.scheduler.nodes)```. node.meta["buff_meta"] tracks buf_name 

 
<img width="350" alt="Screenshot 2023-08-29 at 12 40 24 PM" src="https://github.com/pytorch/pytorch/assets/134637289/c4e197cb-ab3b-4a09-a584-c1356376accb">
<img width="300" alt="Screenshot 2023-08-29 at 12 42 06 PM" src="https://github.com/pytorch/pytorch/assets/134637289/1f90b82d-2efa-4830-a8dd-1fed958e46ec">




cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

weifengpy added a commit that referenced this pull request


          [in progress][inductor] visualize fused ops in svg graph

90c8d2c

ghstack-source-id: 6c07dc9
Pull Request resolved: #107752


          Update on "[inductor] visualize fused ops in svg graph"

28c146c

example usage
* `TORCH_COMPILE_DEBUG=1 INDUCTOR_ORIG_FX_SVG=1 INDUCTOR_POST_FUSION_SVG=1 python trig.py`: show original fx node name, file, and code. see snapshot 2 where we have origin_0, 1, 2
* trig.py can be found in P816304818

Implementation
* keep original fx graph in GraphLowering, ```self.orig_gm: torch.fx.GraphModule = gm.__copy__()```
* draw original fx graph with origins ir_post_fusion ```V.debug.draw_orig_fx_graph(self.orig_gm, self.scheduler.nodes)```. node.meta["buff_meta"] tracks buf_name 

 
<img width="350" alt="Screenshot 2023-08-29 at 12 40 24 PM" src="https://github.com/pytorch/pytorch/assets/134637289/c4e197cb-ab3b-4a09-a584-c1356376accb">


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

weifengpy added a commit that referenced this pull request


          [in progress][inductor] visualize fused ops in svg graph

74a3928

ghstack-source-id: 8248728
Pull Request resolved: #107752


          Update on "[inductor] visualize fused ops in svg graph"

990e03e

example usage
* `TORCH_COMPILE_DEBUG=1 INDUCTOR_ORIG_FX_SVG=1 INDUCTOR_POST_FUSION_SVG=1 python trig.py`: show original fx node name, file, and code. see snapshot 2 where we have origin_0, 1, 2
* trig.py can be found in P816304818

Implementation
* keep original fx graph in GraphLowering, ```self.orig_gm: torch.fx.GraphModule = gm.__copy__()```
* draw original fx graph with origins ir_post_fusion ```V.debug.draw_orig_fx_graph(self.orig_gm, self.scheduler.nodes)```. node.meta["buff_meta"] tracks buf_name 

 
<img width="350" alt="Screenshot 2023-08-29 at 12 40 24 PM" src="https://github.com/pytorch/pytorch/assets/134637289/c4e197cb-ab3b-4a09-a584-c1356376accb">


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

weifengpy added a commit that referenced this pull request


          [in progress][inductor] visualize fused ops in svg graph

efa45b2

ghstack-source-id: e069b4f
Pull Request resolved: #107752

mlazos approved these changes

View reviewed changes

weifengpy added the topic: not user facing label

Contributor Author

weifengpy commented Sep 19, 2023

@pytorchmergebot merge

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Sep 19, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Collaborator

pytorchmergebot commented Sep 19, 2023

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x efa45b28d169bfd451b80815bcc432fa7b91b30b returned non-zero exit code 1

Auto-merging torch/_inductor/config.py
Auto-merging torch/_inductor/debug.py
CONFLICT (content): Merge conflict in torch/_inductor/debug.py
Auto-merging torch/fx/graph.py
error: could not apply efa45b28d16... [in progress][inductor] visualize fused ops in svg graph
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

pytorchmergebot removed the merging label


          Update on "[inductor] visualize fused ops in svg graph"

792c3fe

example usage
* `TORCH_COMPILE_DEBUG=1 INDUCTOR_ORIG_FX_SVG=1 INDUCTOR_POST_FUSION_SVG=1 python trig.py`: show original fx node name, file, and code. see snapshot 2 where we have origin_0, 1, 2
* trig.py can be found in P816304818

Implementation
* keep original fx graph in GraphLowering, ```self.orig_gm: torch.fx.GraphModule = gm.__copy__()```
* draw original fx graph with origins ir_post_fusion ```V.debug.draw_orig_fx_graph(self.orig_gm, self.scheduler.nodes)```. node.meta["buff_meta"] tracks buf_name 

 
<img width="350" alt="Screenshot 2023-08-29 at 12 40 24 PM" src="https://github.com/pytorch/pytorch/assets/134637289/c4e197cb-ab3b-4a09-a584-c1356376accb">


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]


          Update on "[inductor] visualize fused ops in svg graph"

42bd4ec

example usage
* `TORCH_COMPILE_DEBUG=1 INDUCTOR_ORIG_FX_SVG=1 INDUCTOR_POST_FUSION_SVG=1 python trig.py`: show original fx node name, file, and code. see snapshot 2 where we have origin_0, 1, 2
* trig.py can be found in P816304818

Implementation
* keep original fx graph in GraphLowering, ```self.orig_gm: torch.fx.GraphModule = gm.__copy__()```
* draw original fx graph with origins ir_post_fusion ```V.debug.draw_orig_fx_graph(self.orig_gm, self.scheduler.nodes)```. node.meta["buff_meta"] tracks buf_name 

 
<img width="350" alt="Screenshot 2023-08-29 at 12 40 24 PM" src="https://github.com/pytorch/pytorch/assets/134637289/c4e197cb-ab3b-4a09-a584-c1356376accb">


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

weifengpy added a commit that referenced this pull request


          [in progress][inductor] visualize fused ops in svg graph

c1de171

ghstack-source-id: 9e3f51d
Pull Request resolved: #107752

Contributor Author

weifengpy commented Sep 21, 2023

@pytorchmergebot merge

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Sep 21, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added Merged and removed merging labels

pytorchmergebot closed this in

772e104

facebook-github-bot deleted the gh/weifengpy/2/head branch

September 24, 2023 14:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Merged module: inductor release notes: fx topic: not user facing