[inductor] WeakDep should not prevent dead node elimination #107813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A WeakDep is classed as a read dependency but the buffer is never actually read. Instead it only effects schedule ordering. So for the purposes of dead node elimination we should ignore WeakDeps. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107813
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f19fa87 with merge base 55d6b80 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
A WeakDep is classed as a read dependency but the buffer is never actually read. Instead it only effects schedule ordering. So for the purposes of dead node elimination we should ignore WeakDeps. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
A WeakDep is classed as a read dependency but the buffer is never actually read. Instead it only effects schedule ordering. So for the purposes of dead node elimination we should ignore WeakDeps. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
jansel
approved these changes
Aug 25, 2023
mlazos
approved these changes
Aug 25, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
mlazos
reviewed
Aug 25, 2023
voznesenskym
pushed a commit
that referenced
this pull request
Aug 27, 2023
A WeakDep is classed as a read dependency but the buffer is never actually read. Instead it only effects schedule ordering. So for the purposes of dead node elimination we should ignore WeakDeps. Pull Request resolved: #107813 Approved by: https://github.com/jansel, https://github.com/mlazos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
A WeakDep is classed as a read dependency but the buffer is never actually read.
Instead it only effects schedule ordering. So for the purposes of dead node
elimination we should ignore WeakDeps.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov