Skip to content

Conversation

davidberard98
Copy link
Contributor

@davidberard98 davidberard98 commented Aug 24, 2023

Stack from ghstack (oldest at bottom):

I don't know why these are getting called. But, they only get called on cuda machines, which is breaking tests (#100728).

We can just prune them so that the same result is shown for both CPU and CUDA tests.

I don't know why these are getting called. But, they only get called on cuda machines, which is breaking tests.

We can just prune them so that the same result is shown for both CPU and CUDA tests.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 24, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107887

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 39dcf47 with merge base 64d5851 (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 24, 2023
davidberard98 added a commit that referenced this pull request Aug 24, 2023
I don't know why these are getting called. But, they only get called on cuda machines, which is breaking tests.

We can just prune them so that the same result is shown for both CPU and CUDA tests.

ghstack-source-id: 117652e
Pull Request resolved: #107887
@davidberard98 davidberard98 marked this pull request as ready for review August 24, 2023 18:47
Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidberard98
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 24, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/davidberard98/227/head branch August 28, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants