Skip to content

[ONNX] Return input itself for non-fp inputs and support decimals for aten::round op #107920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ONNX] Return input itself for non-fp inputs and support decimals for aten::round op #107920

wants to merge 1 commit into from

Conversation

CYuxian
Copy link
Contributor

@CYuxian CYuxian commented Aug 25, 2023

No description provided.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Aug 25, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 25, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107920

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7792304 with merge base 49eeca0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@CYuxian CYuxian force-pushed the fix-round branch 2 times, most recently from 57ad4bd to f95018c Compare August 25, 2023 03:03
@justinchuby
Copy link
Collaborator

Thanks for contributing! Could you enable the test in https://github.com/pytorch/pytorch/blob/f95018c2813ce5239cb956de8549f4b17005e43f/test/onnx/test_op_consistency.py as well?

@justinchuby justinchuby added the module: onnx Related to torch.onnx label Aug 25, 2023
@justinchuby justinchuby changed the title [onnx] Return input itself for non-fp inputs and support decimals for aten::round op [ONNX] Return input itself for non-fp inputs and support decimals for aten::round op Aug 25, 2023
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 25, 2023
@janeyx99 janeyx99 requested a review from justinchuby August 25, 2023 19:23
@janeyx99
Copy link
Contributor

Adding @justinchuby as reviewer fyi

@justinchuby justinchuby self-assigned this Aug 25, 2023
@justinchuby justinchuby mentioned this pull request Aug 25, 2023
Merged
@CYuxian
Copy link
Contributor Author

CYuxian commented Aug 26, 2023

Thanks for contributing! Could you enable the test in https://github.com/pytorch/pytorch/blob/f95018c2813ce5239cb956de8549f4b17005e43f/test/onnx/test_op_consistency.py as well?

Sure. Just enabled the test in test_op_consistency.py. Please help to review, thanks!

@justinchuby justinchuby added this to the 2.1.0 milestone Aug 26, 2023
@justinchuby justinchuby added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 26, 2023
@justinchuby
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

justinchuby added a commit to microsoft/onnxscript that referenced this pull request Aug 26, 2023
@justinchuby
Implement aten::round.decimals | feat(torchlib) (#1028)
63df31e 
Reference: pytorch/pytorch#107920
voznesenskym pushed a commit that referenced this pull request Aug 27, 2023
@CYuxian @voznesenskym
[ONNX] Return input itself for non-fp inputs and support decimals for…
3c58e05 
… aten::round op (#107920)

Pull Request resolved: #107920
Approved by: https://github.com/justinchuby
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinchuby justinchuby justinchuby approved these changes

@BowenBao BowenBao Awaiting requested review from BowenBao

@abock abock Awaiting requested review from abock

@thiagocrepaldi thiagocrepaldi Awaiting requested review from thiagocrepaldi

@wschin wschin Awaiting requested review from wschin

Assignees

@justinchuby justinchuby

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

ONNX
Status: Done

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@CYuxian @justinchuby @janeyx99 @pytorchmergebot @pytorchbot