[fx][split] Copy node metadata for placeholders #107981
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Follow-up for pytorch#107248 which copies metadata for placeholder nodes in the top-level FX graph
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107981
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 47b4b5e with merge base 7ef13b1 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
bdhirsh
added
the
triaged
angelayi
approved these changes
Aug 31, 2023
|
@gs-olive Can you add some tests in a separate PR? |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@gmagogsfm - testing for this PR is added in #108731. |
angelayi
pushed a commit
that referenced
this pull request
Sep 14, 2023
- Follow-up to #107248 which copies metadata for placeholder nodes in the top-level FX graph - Currently, top-level placeholders do not have their metadata copied over, causing loss of `TensorMetadata` in some `torch.compile` backends Fixes pytorch/TensorRT#2258 Pull Request resolved: #107981 Approved by: https://github.com/angelayi
This was referenced Sep 14, 2023
atalman
pushed a commit
that referenced
this pull request
Sep 14, 2023
- Follow-up to #107248 which copies metadata for placeholder nodes in the top-level FX graph - Currently, top-level placeholders do not have their metadata copied over, causing loss of `TensorMetadata` in some `torch.compile` backends Fixes pytorch/TensorRT#2258 Pull Request resolved: #107981 Approved by: https://github.com/angelayi Co-authored-by: gs-olive <113141689+gs-olive@users.noreply.github.com>
|
this was included in 2.1.0 hence removing from milestones |
pytorchmergebot
pushed a commit
to gs-olive/pytorch
that referenced
this pull request
Dec 15, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 18, 2023
- Follow-up to #107981, adding testing for metadata copying in placeholder nodes within the `split_by_tags` utility - Validation included in the test from #107248, since both tests are relevant to the same aspect of the utility Pull Request resolved: #108731 Approved by: https://github.com/angelayi
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
- Follow-up to pytorch#107981, adding testing for metadata copying in placeholder nodes within the `split_by_tags` utility - Validation included in the test from pytorch#107248, since both tests are relevant to the same aspect of the utility Pull Request resolved: pytorch#108731 Approved by: https://github.com/angelayi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorMetadatain sometorch.compilebackendsFixes pytorch/TensorRT#2258