Skip to content

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Aug 25, 2023

Logging regarding which tests are serial + parallel + what tests actually get run on the shard got removed, which can be pretty helpful, so this adds it back in.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 25, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 25, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107987

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2496baf with merge base e58d3ed (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 marked this pull request as ready for review August 28, 2023 22:49
@clee2000 clee2000 requested a review from a team as a code owner August 28, 2023 22:49
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clee2000
Copy link
Contributor Author

clee2000 commented Sep 1, 2023

@pytorchbot merge -f "pull passed, trunk not needed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the csl/logging branch March 3, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants