Skip to content

Fix the use of inputs.build_environment in #107868 #108075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix the use of inputs.build_environment in #107868 #108075

wants to merge 1 commit into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Aug 28, 2023

It should be ${{ inputs.build_environment }}, although I wonder why not just clean up the artifacts directory for all build instead of just aarch64

@huydhn huydhn requested a review from atalman August 28, 2023 17:47
@huydhn huydhn requested a review from a team as a code owner August 28, 2023 17:47
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 28, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 28, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108075

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 20307bb with merge base 7349e8c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn requested a review from DanilBaibak August 28, 2023 18:25
atalman
atalman approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huydhn
Copy link
Contributor Author

huydhn commented Aug 28, 2023

@pytorchbot merge -f 'A simple CI change, lint jobs are sufficient'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

huydhn added a commit to huydhn/pytorch that referenced this pull request Aug 29, 2023
@huydhn
Fix the use of inputs.build_environment in pytorch#107868 (pytorch#10…
39f57df 
…8075)

It should be `${{ inputs.build_environment }}`, although I wonder why not just clean up the artifacts directory for all build instead of just `aarch64`
Pull Request resolved: pytorch#108075
Approved by: https://github.com/atalman, https://github.com/seemethere
@huydhn huydhn mentioned this pull request Aug 29, 2023
Closed
atalman pushed a commit that referenced this pull request Aug 30, 2023
@huydhn
Fix the use of inputs.build_environment in #107868 (#108075) (#108177)
9175987 
It should be `${{ inputs.build_environment }}`, although I wonder why not just clean up the artifacts directory for all build instead of just `aarch64`
Pull Request resolved: #108075
Approved by: https://github.com/atalman, https://github.com/seemethere
@huydhn huydhn deleted the fix-107868 branch October 13, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@atalman atalman atalman approved these changes

@DanilBaibak DanilBaibak Awaiting requested review from DanilBaibak

Assignees

No one assigned

Labels

Merged test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huydhn @pytorchmergebot @seemethere @atalman