Skip to content

Conversation

FFFrog
Copy link
Collaborator

@FFFrog FFFrog commented Sep 5, 2023

As stated in this #107207 (comment), packaging is not a built-in python module and need to add it to requirements.txt.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108554

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b878c1a with merge base efc7c36 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 5, 2023
@FFFrog FFFrog requested a review from albanD September 5, 2023 03:37
@FFFrog
Copy link
Collaborator Author

FFFrog commented Sep 5, 2023

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased mrl_fix_packaging onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout mrl_fix_packaging && git pull --rebase)

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@albanD
Copy link
Collaborator

albanD commented Sep 6, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 6, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@FFFrog FFFrog deleted the mrl_fix_packaging branch September 7, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants