Skip to content

[export] Fix unlifting pass param name handling. #108659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[export] Fix unlifting pass param name handling. #108659

wants to merge 1 commit into from

Conversation

zhxchen17
Copy link
Contributor

Summary: Fixing an internal test.

Differential Revision: D49014757

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 6, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108659

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 25ba81b with merge base 8a76f8e (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 6, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: zhxchen17 / name: Zhengxu Chen (25ba81b)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49014757

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49014757

@zhxchen17 zhxchen17 added the topic: not user facing topic category label Sep 6, 2023
@zhxchen17 zhxchen17 mentioned this pull request Sep 6, 2023
Closed
@facebook-github-bot
Copy link
Contributor

@zhxchen17 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zhxchen17 @facebook-github-bot
[export] Fix unlifting pass param name handling. (pytorch#108659)
25ba81b 
Summary:
Fixing an internal test.


Differential Revision: D49014757

Pulled By: zhxchen17
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49014757

@zhxchen17
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 6, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@huydhn
Copy link
Contributor

huydhn commented Sep 7, 2023

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-jammy-py3.8-gcc11 / test (docs_test, 1, 1, linux.2xlarge), pull / linux-docs / build-docs-python-false

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhxchen17 @facebook-github-bot @pytorchmergebot @huydhn