Skip to content

[experimental] use EXCEPT_FOR env to suppress CPU tests from GPU RE #108672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[experimental] use EXCEPT_FOR env to suppress CPU tests from GPU RE #108672

wants to merge 1 commit into from

Conversation

@mikekgfb
Copy link
Contributor

@mikekgfb mikekgfb commented Sep 6, 2023

Summary:
[experimental] use EXCEPT_FOR env to suppress CPU tests from GPU RE -- alternative implementation to D48997976 using preexisting PYTORCH_TESTING_DEVICE_EXCEPT_FOR facility and building remaining logic (for assert-positive listers like test_transformers) on top of that.

Goal: save ~100 GPU (10% of capacity), enables us to fund more aggressive PyPer unit testing on GPU RE

Test Plan: sandcastle, github

Differential Revision: D48998582

@mikekgfb mikekgfb requested a review from a team as a code owner September 6, 2023 17:19
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 6, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108672

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 150d121 with merge base e5e653a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48998582

@mikekgfb mikekgfb requested a review from bertmaher September 6, 2023 17:20
@mikekgfb mikekgfb added the topic: not user facing topic category label Sep 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48998582

@facebook-github-bot
[experimental] use EXCEPT_FOR env to suppress CPU tests from GPU RE (p…
150d121 
…ytorch#108672)

Summary:

[experimental] use EXCEPT_FOR env to suppress CPU tests from GPU RE -- alternative implementation to D48997976 using preexisting PYTORCH_TESTING_DEVICE_EXCEPT_FOR facility and building remaining logic (for assert-positive listers like test_transformers)  on top of that.

Goal: save ~100 GPU (10% of capacity), enables us to fund more aggressive PyPer unit testing on GPU RE

Test Plan: sandcastle, github

Differential Revision: D48998582
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48998582

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48998582

@mikekgfb
Copy link
Contributor Author

mikekgfb commented Sep 6, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 6, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bertmaher bertmaher bertmaher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikekgfb @facebook-github-bot @pytorchmergebot @bertmaher