Re-enable some Windows tests #108930
Re-enable some Windows tests #108930
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108930
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e793d19 with merge base 8ff0036 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot label ciflows/trunk |
|
Didn't find following labels among repository labels: ciflows/trunk |
|
@pytorchbot label ciflow/trunk |
|
@pytorchbot label ciflow/binaries |
pytorch-bot
bot
added
the
ciflow/binaries
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
pytorchmergebot
force-pushed
the
win_test
branch
from
20176a9 to
312ae8c
Compare
drisspg
added
the
triaged
| :: Skip LibTorch tests when building a GPU binary and testing on a CPU machine | ||
| :: because LibTorch tests are not well designed for this use case. | ||
| if "%USE_CUDA%" == "0" IF NOT "%CUDA_VERSION%" == "cpu" exit /b 0 | ||
| ::if "%USE_CUDA%" == "0" IF NOT "%CUDA_VERSION%" == "cpu" exit /b 0 |
There was a problem hiding this comment.
I wonder why is this commented out instead of removal?
| if "%~1" == "module_test" goto :eof | ||
| :: See https://github.com/pytorch/pytorch/issues/25312 | ||
| if "%~1" == "converter_nomigraph_test" goto :eof | ||
| :: See https://github.com/pytorch/pytorch/issues/35636 |
There was a problem hiding this comment.
Please comment on #35636 if you think it's no longer an issue.
| if "%~1" == "converter_nomigraph_test" goto :eof | ||
| :: See https://github.com/pytorch/pytorch/issues/35636 | ||
| if "%~1" == "generate_proposals_op_gpu_test" goto :eof | ||
| :: See https://github.com/pytorch/pytorch/issues/35648 |
There was a problem hiding this comment.
Please comment on #35648 if you think it's no longer an issue.
| if "%~1" == "generate_proposals_op_gpu_test" goto :eof | ||
| :: See https://github.com/pytorch/pytorch/issues/35648 | ||
| if "%~1" == "reshape_op_gpu_test" goto :eof | ||
| :: See https://github.com/pytorch/pytorch/issues/35651 |
There was a problem hiding this comment.
Please comment on #35651 if you think it's no longer an issue.
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Follows the work of #108930. The commented test_custom_classes.py was removed since the file doesn't exist. Pull Request resolved: #109847 Approved by: https://github.com/kit1980
5 participants
The tests were disabled long before. It should be fine to enable them.
Fixes #35651, fixes #35636, fixes #35648.
cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @vladimir-aubrecht @iremyux @Blackhex @cristianPanaite @malfet