Re-land: Break graph on manual_seed.

[ysiraichi]

Stack from ghstack (oldest at bottom):

• -> Re-land: Break graph on manual_seed. #109109

Re-landing: #108647 (old #107594)

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @ngimel

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109109

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit b4a0c65 with merge base 129f535 ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• linux-focal-py3.8-clang10 / test (dynamo, 2, 2, linux.2xlarge) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ysiraichi]

Add support SymInt in Generator.manual_seed.

[ysiraichi]

@anijain2305 I think this PR is ready for review. Could you take a look, if you have some time?

[ysiraichi]

@eellison @anijain2305 This is a friendly reminder. Do you have some time to take a look at this PR?

[lezcano]

Nice targeted fix!

[lezcano]

I re-requested a review on myself because I thought that there could be a way to trace through a program without having disabled manual_seed, but no, I think this can't happen without really bending Python imports.

[ysiraichi]

@pytorchbot merge

[pytorchmergebot]

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 0554e1e38f8953d5513ed888a0f0c0dbaece276f returned non-zero exit code 1

Auto-merging test/dynamo/test_misc.py
Auto-merging test/inductor/test_torchinductor_opinfo.py
Auto-merging torch/_dynamo/variables/torch.py
CONFLICT (content): Merge conflict in torch/_dynamo/variables/torch.py
error: could not apply 0554e1e38f8... Re-land: Break graph on `manual_seed`.
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

[ysiraichi]

@pytorchbot rebase -s

[pytorchmergebot]

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[pytorchmergebot]

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/ysiraichi/86/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging test/dynamo/test_misc.py
Auto-merging test/inductor/test_torchinductor_opinfo.py
Auto-merging torch/_dynamo/variables/torch.py
CONFLICT (content): Merge conflict in torch/_dynamo/variables/torch.py
error: could not apply 0554e1e38f8... Re-land: Break graph on `manual_seed`.
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 0554e1e38f8... Re-land: Break graph on `manual_seed`.

Raised by https://github.com/pytorch/pytorch/actions/runs/6315677704

[ysiraichi]

The CI failure seems to be coming from upstream.

[ysiraichi]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

• pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 2, linux.2xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

[lezcano]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

• pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 2, linux.2xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

[ysiraichi]

@pytorchbot merge -i

[pytorchmergebot]

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 2, linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here