Skip to content

Don't use cpuinfo on s390x #109496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Don't use cpuinfo on s390x #109496

wants to merge 1 commit into from

Conversation

@AlekseiNikiforovIBM
Copy link
Collaborator

It doesn't support s390x and just crashes pytorch on init.

@AlekseiNikiforovIBM
Don't use cpuinfo on s390x
e6b3f8b 
It doesn't support s390x and just crashes pytorch on init
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 18, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109496

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit e6b3f8b with merge base c7017ff (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@AlekseiNikiforovIBM
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 18, 2023
@huydhn
Copy link
Contributor

huydhn commented Sep 20, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 20, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 3, 3, macos-m1-12)

Details for Dev Infra team Raised by workflow job

@AlekseiNikiforovIBM
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@AlekseiNikiforovIBM AlekseiNikiforovIBM mentioned this pull request Sep 22, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Sep 26, 2023
@AlekseiNikiforovIBM @pytorchmergebot
Don't link to libcpuinfo on s390x (#109875)
e05eb69 
Don't even build it.
It does not support s390x.

This is a follow up for #109496

Pull Request resolved: #109875
Approved by: https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlekseiNikiforovIBM @huydhn @pytorchmergebot @pytorchbot