[optests] Test names in failure dicts should be prefixed with test class #110045
Conversation
We want to use the same failures dict for multiple TestCase. This happens common in e.g. fbgemm. To move towards that, we need to prefix each test name with their test class to avoid ambiguity Differential Revision: [D49615962](https://our.internmc.facebook.com/intern/diff/D49615962/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110045
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d10aae3 with merge base cd99cdc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
We want to use the same failures dict for multiple TestCase. This happens common in e.g. fbgemm. To move towards that, we need to prefix each test name with their test class to avoid ambiguity Differential Revision: [D49615962](https://our.internmc.facebook.com/intern/diff/D49615962/) ghstack-source-id: 201870796 Pull Request resolved: #110045
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -c nosignal -m "breaking linux-focal-py3.8-clang10" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
Can't revert PR that was landed via phabricator as D49615962. Please revert by going to the internal diff and clicking Unland. |
|
@jeanschmidt the test failure looks unrelated to this PR |
|
Original PR passed the tests: |
|
@pytorchbot revert -m="Diff reverted internally" -c="ghfirst" This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).) |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@zou3519 your PR has been successfully reverted. |
… test class (#110045)" This reverts commit 76fcec7. Reverted #110045 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#110045 (comment)))
5 participants
Stack from ghstack (oldest at bottom):
We want to use the same failures dict for multiple TestCase. This happens
common in e.g. fbgemm. To move towards that, we need to prefix each test name
with their test class to avoid ambiguity
Differential Revision: D49615962