Skip to content

Conversation

@albanD
Copy link
Collaborator

@albanD albanD commented Sep 26, 2023

Cover the basic principles of Mode and an example on how to use them and their behavior.

@albanD albanD requested a review from janeyx99 September 26, 2023 12:01
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110073

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 6391553 with merge base a3e5ec4 (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool pr! left some grammatical nits. appreciated the example, but i don’t come away knowing which mode i should use (the blatant difference to me seems to be aten vs torch api). a question i still don’t quite know the answer to: when should dispatch mode be used with subclasses?

also cc @drisspg who mentioned wanting a wiki like this before

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do more here to explain when someone would use torch function vs torch dispatch

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two previous sections should be describing these in details already.
And I do plan to add an intro with the big "when to use what" diagram. I will do that in a follow up!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes

@albanD
Copy link
Collaborator Author

albanD commented Oct 6, 2023

@pytorchbot merge -r

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 6, 2023

This PR needs to be approved by an authorized maintainer before merge.

@janeyx99
Copy link
Contributor

janeyx99 commented Oct 6, 2023

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 6, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased extending_doc_update onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout extending_doc_update && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@albanD albanD added the topic: not user facing topic category label Oct 6, 2023
@albanD
Copy link
Collaborator Author

albanD commented Oct 6, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants