Skip to content

[dynamo][easy] Move code from GetAttrVariable to a suitable place #110535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[dynamo][easy] Move code from GetAttrVariable to a suitable place #110535

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e28c2f
[dynamo][easy] Move code from GetAttrVariable to a suitable place
anijain2305 Oct 4, 2023
28112cb
Update on "[dynamo][easy] Move code from GetAttrVariable to a suitabl…
anijain2305 Oct 4, 2023
a7d4916
Update on "[dynamo][easy] Move code from GetAttrVariable to a suitabl…
anijain2305 Oct 4, 2023
c5b9b8f
Update on "[dynamo][easy] Move code from GetAttrVariable to a suitabl…
anijain2305 Oct 8, 2023
cb174ca
Update on "[dynamo][easy] Move code from GetAttrVariable to a suitabl…
anijain2305 Oct 8, 2023
c723135
Update on "[dynamo][easy] Move code from GetAttrVariable to a suitabl…
anijain2305 Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions torch/_dynamo/variables/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,10 @@ def call_method(
args: "List[VariableTracker]",
kwargs: "Dict[str, VariableTracker]",
):
if name == "backward":
if name == "apply":
options = VariableTracker.propagate(self, args, kwargs.values())
return self.call_apply(tx, args, kwargs).add_options(options)
elif name == "backward":
with tx.strict_translation_mode():
if isinstance(self.fn_cls.backward, types.FunctionType):
backward = UserFunctionVariable(self.fn_cls.backward)
Expand Down Expand Up @@ -642,8 +645,6 @@ def reconstruct(self, codegen):
def call_function(
self, tx, args: "List[VariableTracker]", kwargs: "Dict[str, VariableTracker]"
) -> "VariableTracker":
if isinstance(self.obj, AutogradFunctionVariable) and self.name == "apply":
return self.obj.call_apply(tx, args, kwargs).add_options(self)
return self.obj.call_method(tx, self.name, args, kwargs).add_options(self)

def call_method(
Expand Down