-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Support Numpy ints in the torch.nn.functional.interpolate
dtype check
#110778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110778
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 09e9f13 with merge base 563728f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
torch.nn.functional.interpolate
dtype checktorch.nn.functional.interpolate
dtype check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok since the linked comment mentioned that interpolate used to work with size as a tuples of numpy integers on 2.0.1
Co-authored-by: mikaylagawarecki <mikaylagawarecki@gmail.com>
@pytorchbot merge -g |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
In #99243, a check was added to ensure the
size
only contained integers.This PR updates the check to also include numpy integers based on this comment (cc @kit1980): #99243 (comment). Similar to the other commenter, I also ran into issues where existing software broke due to this after upgrading to PT2.1: