Skip to content

[tgif][multiforward] allow codegen to generate different func name #111446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[tgif][multiforward] allow codegen to generate different func name #111446

wants to merge 1 commit into from

Conversation

@strisunshinewentingwang
Copy link
Contributor

Summary: see Shiyan's design doc for ATM TS publish weights dedupe https://fb.quip.com/HnUVAjUMaXMQ

Test Plan: tested in N4454041 after D50341352 that multiforward method is working for ts model

Differential Revision: D45750812

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111446

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f5714b1 with merge base ca5f6f7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Oct 18, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45750812

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45750812

@842974287 @facebook-github-bot
[tgif ts][multiforward] allow codegen to generate different func name (…
f5714b1 
…pytorch#111446)

Summary: Pull Request resolved: pytorch#111446

Reviewed By: 842974287

Differential Revision: D45750812
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45750812

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 19, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@842974287 @xuhancn
[tgif][multiforward] allow codegen to generate different func name (p…
e56b61a 
…ytorch#111446)

Summary: see Shiyan's design doc for ATM TS publish weights dedupe https://fb.quip.com/HnUVAjUMaXMQ

Test Plan: tested in N4454041 after D50341352 that multiforward method is working for ts model

Differential Revision: D45750812

Pull Request resolved: pytorch#111446
Approved by: https://github.com/842974287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@842974287 842974287 842974287 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@strisunshinewentingwang @facebook-github-bot @pytorchmergebot @842974287