Skip to content

Conversation

leslie-fang-intel
Copy link
Collaborator

@leslie-fang-intel leslie-fang-intel commented Oct 26, 2023

Stack from ghstack (oldest at bottom):

Summary
As discussed in #109019, the accuracy issue of GPT2ForSequenceClassification has been fixed in #108690. Remove it from CI Skip list.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112100

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit 1a5c8aa with merge base 0ec66b3 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@lezcano
Copy link
Collaborator

lezcano commented Oct 26, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

@lezcano
Copy link
Collaborator

lezcano commented Oct 26, 2023

GPT2ForSequenceClassification still fails accuracy on CI?

@leslie-fang-intel
Copy link
Collaborator Author

GPT2ForSequenceClassification still fails accuracy on CI?

Yean, it passes in my local system. Not sure the difference yet.

…ip list"


**Summary**
As discussed in #109019, the accuracy issue of `GPT2ForSequenceClassification` has been fixed in #108690. Remove it from CI Skip list.


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
leslie-fang-intel added a commit that referenced this pull request Nov 19, 2023
@leslie-fang-intel
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@leslie-fang-intel
Copy link
Collaborator Author

After rebasing to master, GPT2ForSequenceClassification pass the accuracy check now.

facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Nov 20, 2023
Summary:
**Summary**
As discussed in pytorch/pytorch#109019, the accuracy issue of `GPT2ForSequenceClassification` has been fixed in pytorch/pytorch#108690. Remove it from CI Skip list.

X-link: pytorch/pytorch#112100
Approved by: https://github.com/lezcano

Reviewed By: DanilBaibak

Differential Revision: D51468262

fbshipit-source-id: da20682b65fcdccab7dbf61ba73d71f9f9fca661
@facebook-github-bot facebook-github-bot deleted the gh/leslie-fang-intel/34/head branch November 22, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants