Skip to content

Conversation

mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Oct 26, 2023

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112212

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a98e5cb with merge base a81edf9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Oct 26, 2023
ghstack-source-id: 18c516f
Pull Request resolved: #112212
mikaylagawarecki added a commit that referenced this pull request Oct 31, 2023
ghstack-source-id: 8dab0ba
Pull Request resolved: #112212
mikaylagawarecki added a commit that referenced this pull request Nov 10, 2023
ghstack-source-id: 106c25e
Pull Request resolved: #112212
mikaylagawarecki added a commit that referenced this pull request Nov 10, 2023
ghstack-source-id: 0a850ee
Pull Request resolved: #112212
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/mikaylagawarecki/156/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/112212)

pytorchmergebot pushed a commit that referenced this pull request Dec 19, 2023
ghstack-source-id: 792667e
Pull Request resolved: #112212
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As discussed offline, I'm okay with a simple global setting instead of a context manager. I do think we need a test or two though for validation.



def set_fastpath_enabled(value: bool) -> None:
"""Sets whether fast path is enabled"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might be worth mentioning here or above in the getter that even if the fast-path is enabled, it still has to satisfy other conditions to be taken

mikaylagawarecki added a commit that referenced this pull request Dec 22, 2023
ghstack-source-id: 853fd84
Pull Request resolved: #112212
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/mikaylagawarecki/156/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/112212)

mikaylagawarecki added a commit that referenced this pull request Dec 26, 2023
ghstack-source-id: 1bf3ec0
Pull Request resolved: #112212
@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review December 27, 2023 17:41
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 2, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/mikaylagawarecki/156/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/112212)

pytorchmergebot pushed a commit that referenced this pull request Jan 2, 2024
ghstack-source-id: a7551a0
Pull Request resolved: #112212
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@mikaylagawarecki mikaylagawarecki added release notes: nn release notes category topic: improvements topic category labels Jan 2, 2024
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nn release notes category topic: improvements topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants