-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add config to disable TransformerEncoder/MHA fastpath #112212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config to disable TransformerEncoder/MHA fastpath #112212
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112212
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a98e5cb with merge base a81edf9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
[ghstack-poisoned]
Successfully rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! As discussed offline, I'm okay with a simple global setting instead of a context manager. I do think we need a test or two though for validation.
|
||
|
||
def set_fastpath_enabled(value: bool) -> None: | ||
"""Sets whether fast path is enabled""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: might be worth mentioning here or above in the getter that even if the fast-path is enabled, it still has to satisfy other conditions to be taken
[ghstack-poisoned]
[ghstack-poisoned]
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
[ghstack-poisoned]
Successfully rebased |
[ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@pytorchbot merge -r |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
[ghstack-poisoned]
Successfully rebased |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):