-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Remove c10::either #112733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove c10::either #112733
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112733
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 6bd4b1f with merge base 67c8ad7 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@albanD A missing change was submitted, have to re-import |
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge Fixed internal failures in the linked diff. |
|
This PR needs to be approved by an authorized maintainer before merge. |
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
6b09024 to
5caa06b
Compare
|
I have to reapply internal patch and everything. Please don't merge |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
5caa06b to
0cb6f00
Compare
|
@albanD Should we merge it? |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
0cb6f00 to
6bd4b1f
Compare
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge Sorry for the delay, take forever to get my internal env setup again every time. Should be good now |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Time to remove it. Pull Request resolved: pytorch#112733 Approved by: https://github.com/albanD
Time to remove it.
cc @albanD