Skip to content

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Nov 2, 2023

Time to remove it.

cc @albanD

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 2, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112733

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 6bd4b1f with merge base 67c8ad7 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cyyever
Copy link
Collaborator Author

cyyever commented Nov 2, 2023

@albanD A missing change was submitted, have to re-import

@facebook-github-bot
Copy link
Contributor

@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jbschlosser jbschlosser added the better-engineering Relatively self-contained tasks for better engineering contributors label Nov 2, 2023
@jbschlosser jbschlosser requested a review from albanD November 2, 2023 17:52
@jbschlosser jbschlosser added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 2, 2023
@albanD
Copy link
Collaborator

albanD commented Nov 3, 2023

@pytorchbot merge

Fixed internal failures in the linked diff.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2023

This PR needs to be approved by an authorized maintainer before merge.

@albanD
Copy link
Collaborator

albanD commented Nov 3, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 3, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented Nov 4, 2023

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 4, 2023
@cyyever
Copy link
Collaborator Author

cyyever commented Nov 4, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased no_either onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout no_either && git pull --rebase)

@albanD
Copy link
Collaborator

albanD commented Nov 9, 2023

I have to reapply internal patch and everything. Please don't merge

@cyyever
Copy link
Collaborator Author

cyyever commented Dec 5, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased no_either onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout no_either && git pull --rebase)

@cyyever
Copy link
Collaborator Author

cyyever commented Dec 5, 2023

@albanD Should we merge it?

@albanD
Copy link
Collaborator

albanD commented Dec 6, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased no_either onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout no_either && git pull --rebase)

@facebook-github-bot
Copy link
Contributor

@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@albanD
Copy link
Collaborator

albanD commented Dec 6, 2023

@pytorchbot merge

Sorry for the delay, take forever to get my internal env setup again every time. Should be good now

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the no_either branch December 7, 2023 02:20
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
Time to remove it.

Pull Request resolved: pytorch#112733
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants