Skip to content

test_lazy: skip HashTest.Scalar #112747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test_lazy: skip HashTest.Scalar #112747

wants to merge 1 commit into from

Conversation

AlekseiNikiforovIBM
Copy link
Collaborator

Fixes #99883

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 2, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 2, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112747

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7d04d9e with merge base 86196bf (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jbschlosser
jbschlosser reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to fix lint and we're good!

@jbschlosser jbschlosser added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 2, 2023
@AlekseiNikiforovIBM
Copy link
Collaborator Author

@jbschlosser, could you please take a look at it once more?

@huydhn
Copy link
Contributor

huydhn commented Nov 15, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 15, 2023
@huydhn huydhn added test-config/default and removed ciflow/trunk Trigger trunk jobs on your pull request labels Nov 15, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbschlosser jbschlosser jbschlosser left review comments

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

Merged open source test-config/default topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HashTest.Scalar from test_lazy is broken

5 participants

@AlekseiNikiforovIBM @huydhn @pytorchmergebot @jbschlosser @pytorchbot