Skip to content

Conversation

kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented Nov 9, 2023

Part of #109833

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Nov 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113397

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit f4cd5b4 with merge base 6f8fc42 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kurtamohler added a commit that referenced this pull request Nov 9, 2023
ghstack-source-id: 62e5819
Pull Request resolved: #113397
kurtamohler added a commit that referenced this pull request Nov 10, 2023
ghstack-source-id: 09d37d4
Pull Request resolved: #113397
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Nov 10, 2023
ghstack-source-id: 41444ca
Pull Request resolved: pytorch#113397
@kurtamohler
Copy link
Collaborator Author

kurtamohler commented Nov 23, 2023

The failure in cuda12.1-py3.10-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu) is real. Running test_lazy_clone with PYTORCH_TEST_WITH_INDUCTOR=1 does not work, but for some reason, sometimes it says that the test passed even though error messages get printed out.

I just found #114012, which skips the inductor test. I'll add that change to this PR instead.

I'm not sure why the inductor tests are failing. I think it probably makes sense to fix it in a follow up

kurtamohler added a commit that referenced this pull request Nov 23, 2023
ghstack-source-id: 5d715f0
Pull Request resolved: #113397
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Dec 6, 2023
ghstack-source-id: 5d715f0
Pull Request resolved: pytorch#113397
kurtamohler added a commit that referenced this pull request Dec 6, 2023
ghstack-source-id: 794e0ba
Pull Request resolved: #113397
t = torch.tensor((), device=device)
self.assertEqual(t.dtype, t.storage().dtype)

# Note [lazy_clone_ tests with inductor enabled]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to split the test up into multiple tests to get them to pass when inductor is enabled. This note explains what went wrong and the strategy I used to fix it

@vadimkantorov
Copy link
Contributor

vadimkantorov commented Jan 9, 2024

Related idea on copy-on-write/move-semantics: #106584 (comment)

And expressing that clone is not always needed for currently always-copy functions, such as torch.cat with a single-tensor argument

ezyang added a commit that referenced this pull request Jan 10, 2024
ghstack-source-id: 8756b75
Pull Request resolved: #113397
@ezyang
Copy link
Contributor

ezyang commented Jan 10, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor

ezyang commented Jan 10, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: .github/workflows/periodic.yml / win-vs2019-cuda11.8-py3 / test (default, 1, 4, windows.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor

ezyang commented Jan 11, 2024

@pytorchbot merge -f "trunk flakiness only"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/kurtamohler/2/head branch January 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source Reverted topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants