-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Alternate impl #113576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Alternate impl #113576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Nov 14, 2023
cleanup fix tests ghstack-source-id: 8b40753 Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: 8b40753 Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: 8b40753 Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: 8b40753 Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: 8b40753 Pull Request resolved: #113576 Alternate impl undo
voznesenskym
added a commit
that referenced
this pull request
Nov 14, 2023
cleanup fix tests ghstack-source-id: be082c7 Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: be082c7 Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: be082c7 Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: be082c7 Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: be082c7 Pull Request resolved: #113576 Alternate impl undo
voznesenskym
added a commit
that referenced
this pull request
Nov 17, 2023
cleanup fix tests ghstack-source-id: 32e347d Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: 32e347d Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: 32e347d Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: 32e347d Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: 32e347d Pull Request resolved: #113576 Alternate impl undo wip
voznesenskym
added a commit
that referenced
this pull request
Nov 18, 2023
cleanup fix tests ghstack-source-id: d5f0e39 Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: d5f0e39 Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: d5f0e39 Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: d5f0e39 Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: d5f0e39 Pull Request resolved: #113576 Alternate impl undo wip
voznesenskym
added a commit
that referenced
this pull request
Nov 18, 2023
cleanup fix tests ghstack-source-id: d5f0e39 Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: d5f0e39 Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: d5f0e39 Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: d5f0e39 Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: d5f0e39 Pull Request resolved: #113576 Alternate impl undo wip
voznesenskym
added a commit
that referenced
this pull request
Nov 19, 2023
cleanup fix tests ghstack-source-id: e1f5e27 Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: e1f5e27 Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: e1f5e27 Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: e1f5e27 Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: e1f5e27 Pull Request resolved: #113576 Alternate impl undo wip
voznesenskym
added a commit
that referenced
this pull request
Nov 20, 2023
cleanup fix tests ghstack-source-id: 23ef3ab Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: 23ef3ab Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: 23ef3ab Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: 23ef3ab Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: 23ef3ab Pull Request resolved: #113576 Alternate impl undo wip
voznesenskym
added a commit
that referenced
this pull request
Nov 20, 2023
cleanup fix tests ghstack-source-id: 08a4606 Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: 08a4606 Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: 08a4606 Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: 08a4606 Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: 08a4606 Pull Request resolved: #113576 Alternate impl undo wip
voznesenskym
added a commit
that referenced
this pull request
Dec 1, 2023
cleanup fix tests ghstack-source-id: a87bc01 Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: a87bc01 Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: a87bc01 Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: a87bc01 Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: a87bc01 Pull Request resolved: #113576 Alternate impl undo wip Fixes Fixes Fixes wip lint, test fix
voznesenskym
added a commit
that referenced
this pull request
Dec 1, 2023
cleanup fix tests ghstack-source-id: 7a543f8 Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: 7a543f8 Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: 7a543f8 Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: 7a543f8 Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: 7a543f8 Pull Request resolved: #113576 Alternate impl undo wip Fixes Fixes Fixes wip lint, test fix woopsie fix test
voznesenskym
added a commit
that referenced
this pull request
Dec 1, 2023
cleanup fix tests ghstack-source-id: 5343720 Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: 5343720 Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: 5343720 Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: 5343720 Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: 5343720 Pull Request resolved: #113576 Alternate impl undo wip Fixes Fixes Fixes wip lint, test fix woopsie fix test rm replace
voznesenskym
added a commit
that referenced
this pull request
Dec 1, 2023
cleanup fix tests ghstack-source-id: c89b426 Pull Request resolved: #113080 fix tests fix tests fix tests [dynamo] Not working yet - .add_() w/ aot_autograd (missing synthetic_base_info) ghstack-source-id: c89b426 Pull Request resolved: #113081 fix tests aot_autograd fixes fix tests Refactor Revert "[dynamo] Graph break on `setattr(Tensor, "data", Tensor)` (#113043)" This reverts commit ddfe572. ghstack-source-id: c89b426 Pull Request resolved: #113205 Refactor Refactor Refactor Refactor Refactor Refactor cache to shape env ghstack-source-id: c89b426 Pull Request resolved: #113295 cache to shape env fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy fake policy Builder fix Builder fix lint bad test bad test bad tests Alternate impl ghstack-source-id: c89b426 Pull Request resolved: #113576 Alternate impl undo wip Fixes Fixes Fixes wip lint, test fix woopsie fix test rm replace rm replace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng