Skip to content

[torch][fsdp] More informative assertion error when rank mismatch #113765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[torch][fsdp] More informative assertion error when rank mismatch #113765

wants to merge 1 commit into from

Conversation

dongyuzheng
Copy link
Contributor

Summary: I had a job fail due to rank mismatch but didn't find enough information in the assertion message. This change makes the message more informative.

Test Plan:
CI tests and I ran a test job which failed as expected:

Rank 1 has different values for step: 8016.0. Other ranks: 7870.0

Differential Revision: D51322046

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 15, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113765

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dee59a2 with merge base d40d270 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 15, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dongyuzheng / name: Gary (dee59a2)

@pytorch-bot pytorch-bot bot added the release notes: distributed (fsdp) release notes category label Nov 15, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51322046

@wz337 wz337 requested review from fegin and wz337 November 15, 2023 17:26
wz337
wz337 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc. @fegin

@fegin
Copy link
Contributor

fegin commented Nov 15, 2023

@dongyuzheng Please sign CLA

@dongyuzheng
Copy link
Contributor Author

/easycla

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51322046

@dongyuzheng @facebook-github-bot
[torch][fsdp] More informative assertion error when rank mismatch (py…
dee59a2 
…torch#113765)

Summary:

I had a job fail due to rank mismatch but didn't find enough information in the assertion message. This change makes the message more informative.

Test Plan:
CI tests and I ran a test job which failed as expected:

```
Rank 1 has different values for step: 8016.0. Other ranks: 7870.0
```

Reviewed By: wz337, fegin

Differential Revision: D51322046
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51322046

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 20, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fegin fegin fegin approved these changes

@wz337 wz337 wz337 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: distributed (fsdp) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dongyuzheng @facebook-github-bot @fegin @pytorchmergebot @wz337