Skip to content

Disallow fp8 type promotion #113975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Disallow fp8 type promotion #113975

wants to merge 1 commit into from

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Nov 17, 2023 •
edited
Loading

Fixes #113663

As well as updating the promotion logic to disallow automatic type promotion between fp8 types this PR also cleans up the table entries.

@drisspg drisspg requested a review from jerryzh168 as a code owner November 17, 2023 20:14
@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Nov 17, 2023
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 17, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113975

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0d36d3f with merge base dedb47d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@drisspg drisspg force-pushed the disallow_fp8_autocast branch from 33853be to 775a5f6 Compare November 17, 2023 22:02
@drisspg drisspg added the better-engineering Relatively self-contained tasks for better engineering contributors label Nov 17, 2023
drisspg
drisspg commented Nov 17, 2023
View reviewed changes
@albanD albanD requested a review from ngimel November 17, 2023 22:07
@drisspg drisspg force-pushed the disallow_fp8_autocast branch from 775a5f6 to b6f012d Compare November 17, 2023 22:09
albanD
albanD reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of intermediary constants :p But sounds ok to me.

@drisspg drisspg force-pushed the disallow_fp8_autocast branch 2 times, most recently from 00ef21a to e4dbd66 Compare November 18, 2023 00:22
drisspg
drisspg commented Nov 18, 2023
View reviewed changes
@drisspg drisspg force-pushed the disallow_fp8_autocast branch from e4dbd66 to 0d36d3f Compare November 18, 2023 20:43
@drisspg drisspg requested a review from mruberry as a code owner November 18, 2023 20:43
@drisspg drisspg requested a review from albanD November 18, 2023 23:45
albanD
albanD approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@drisspg
Copy link
Contributor Author

drisspg commented Nov 20, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 20, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet added the topic: bc breaking topic category label Dec 5, 2023
@malfet malfet mentioned this pull request Dec 5, 2023
Open
@ezyang ezyang mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@albanD albanD albanD approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

@ngimel ngimel Awaiting requested review from ngimel

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: quantization release notes category topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FP8 types should not participate in type promotion and should have no math ops defined on them

4 participants

@drisspg @pytorchmergebot @malfet @albanD