Skip to content

Conversation

titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Nov 27, 2023

Stack from ghstack (oldest at bottom):

Fix #114166
Fix #113705

This PR references tests from test_export.py to make sure the exported program from PyTorch can all be successfully exported into ONNX model.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Nov 27, 2023
Copy link

pytorch-bot bot commented Nov 27, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114633

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fe0a6c0 with merge base e4b1378 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@titaiwangms titaiwangms marked this pull request as draft November 27, 2023 22:15
titaiwangms added a commit that referenced this pull request Nov 27, 2023
ghstack-source-id: 1c4b91d
Pull Request resolved: #114633
@titaiwangms titaiwangms marked this pull request as ready for review November 27, 2023 22:37
@titaiwangms titaiwangms added topic: not user facing topic category module: onnx Related to torch.onnx labels Nov 27, 2023
"of node (n0__4) does not match expected type (tensor(int64))"
@pytorch_test_common.xfail_if_model_type_is_exportedprogram(
"RuntimeError:"
" Found following user inputs located at [0] are mutated. This is currently banned in the aot_export workflow."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase and retest this test after #114596? it might be fixed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error message changed

This PR references tests from `test_export.py` to make sure the exported program from PyTorch can all be successfully exported into ONNX model.

[ghstack-poisoned]
titaiwangms added a commit that referenced this pull request Nov 28, 2023
ghstack-source-id: 9042198
Pull Request resolved: #114633
@titaiwangms titaiwangms removed the request for review from jeffdaily November 28, 2023 01:16
@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 28, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/titaiwangms/37/head branch December 2, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants