Skip to content

Cleanup .watchman file #114716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Cleanup .watchman file #114716

wants to merge 1 commit into from

Conversation

@eqy
Copy link
Collaborator

@eqy eqy commented Nov 28, 2023

This seems to be an artifact from an fb tool that snuck into a commit (#113117)? CC @malfet

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 28, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114716

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a6e6a55 with merge base 765d459 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 29, 2023
mikaylagawarecki
mikaylagawarecki approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the addition was unintentional to me. cc PR author @stroxler and reviewer @yanboliang

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 29, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Nov 29, 2023

@pytorchbot merge -f "It deletes unused file, so..."

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Nov 29, 2023

Hmm, we should have added this one to .gitignore, PR is coming

malfet added a commit that referenced this pull request Nov 29, 2023
@malfet
[noci] Add .watchman to .gitignore
91ef24a 
Followup after #114716
@malfet malfet mentioned this pull request Nov 29, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Nov 29, 2023
@malfet @pytorchmergebot
[no ci] Add .watchman to .gitignore (#114718)
24f06c7 
Followup after #114716

TODO: should the old filename be deleted, or it just depends on Atom/VSCode version
Pull Request resolved: #114718
Approved by: https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

+1 more reviewer

@yanboliang yanboliang yanboliang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eqy @mikaylagawarecki @pytorchmergebot @malfet @yanboliang