[RelEng] Enable Py312 conda builds #114819
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114819
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7a478cd with merge base 0ced55e ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
[Edit] |
This reverts commit 95f4895. As sympy has been updated to 1.12 with python-3.12 support added see https://anaconda.org/anaconda/sympy/files?version=1.12
huydhn
approved these changes
Dec 2, 2023
|
@pytorchbot merge -f “binary builds are green” |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -f "binary builds are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
malfet
added a commit
that referenced
this pull request
Dec 8, 2023
Currently there is a chicken and egg problem with enabling triton builds for the platform, as package depends on `torch`, so I can only submit this change few days after #114819
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 8, 2023
Currently there is a chicken and egg problem with enabling triton builds for the platform, as package depends on `torch`, so I can only submit this change few days after #114819 Pull Request resolved: #115424 Approved by: https://github.com/clee2000, https://github.com/seemethere
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Once [sympy-1.12](https://anaconda.org/anaconda/sympy/files?version=1.12) has been added it can be build across the board Majority of the changes are in the builder repo: * pytorch/builder@6b8c73f tweaks numpy and openssl deps * pytorch/builder@fc773dd <- tweak MLK requirements for Windows * pytorch/builder@ca378c1 do not depend on Triton * pytorch/builder@3c7404d <- build without GLOO_SSL And finally, to workaround chicken-and-egg problem from [smoke_test.bat:97](https://github.com/pytorch/builder/blob/b92da8cd64c9db81effcb8a48992e69ecb4d6346/windows/internal/smoke_test.bat#L97) ```cmd call conda install -yq numpy pytorch %CONDA_EXTRA_ARGS% ``` Manually upload binaries to pytorch-nightly channel (will fix it akin to Nova in followup PRs) Pull Request resolved: pytorch#114819 Approved by: https://github.com/huydhn
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Currently there is a chicken and egg problem with enabling triton builds for the platform, as package depends on `torch`, so I can only submit this change few days after pytorch#114819 Pull Request resolved: pytorch#115424 Approved by: https://github.com/clee2000, https://github.com/seemethere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once sympy-1.12 has been added it can be build across the board
Majority of the changes are in the builder repo:
And finally, to workaround chicken-and-egg problem from smoke_test.bat:97
Manually upload binaries to pytorch-nightly channel (will fix it akin to Nova in followup PRs)