Skip to content

Fix https://github.com/pytorch/pytorch/issues/114892 #115054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix https://github.com/pytorch/pytorch/issues/114892 #115054

wants to merge 2 commits into from

Conversation

tugsbayasgalan
Copy link
Contributor

@tugsbayasgalan tugsbayasgalan commented Dec 4, 2023 •
edited
Loading

@tugsbayasgalan
Fix #114892
9426249 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 4, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115054

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 92c64b4 with merge base 9cc040f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tugsbayasgalan
Update on "Fix #114892"
92c64b4 
[ghstack-poisoned]
tugsbayasgalan added a commit that referenced this pull request Dec 4, 2023
@tugsbayasgalan
Fix #114892
0a43266 
ghstack-source-id: 7d88570
Pull Request resolved: #115054
@tugsbayasgalan tugsbayasgalan added the topic: not user facing topic category label Dec 4, 2023
bdhirsh
bdhirsh reviewed Dec 4, 2023
View reviewed changes
torch/_functorch/aot_autograd.py
from torch._dynamo.source import ConstantSource
if isinstance(x, int):
# We always specialize on scalar values in export.
if aot_config.is_export:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does export want to do this unconditionally? Or do we (or in the future want to) provide a way for export users to mark scalar inputs as dynamic

Copy link
Contributor Author

@tugsbayasgalan tugsbayasgalan Dec 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to support symint inputs eventually (maybe next half?)

@tugsbayasgalan
Copy link
Contributor Author

@pytorchbot merge -f "Unrelated lint"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

thiagocrepaldi
thiagocrepaldi reviewed Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It would be great if we had an issue to track the "provide a way for export users to mark scalar inputs as dynamic" :)

@facebook-github-bot facebook-github-bot deleted the gh/tugsbayasgalan/174/head branch December 8, 2023 15:30
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@tugsbayasgalan @dmenig
Fix pytorch#114892 (pytorch#115054)
91a0db4 
Pull Request resolved: pytorch#115054
Approved by: https://github.com/bdhirsh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagocrepaldi thiagocrepaldi thiagocrepaldi left review comments

@bdhirsh bdhirsh bdhirsh approved these changes

Assignees

No one assigned

Labels

ciflow/inductor Merged release notes: AO frontend topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tugsbayasgalan @pytorchmergebot @thiagocrepaldi @bdhirsh