Skip to content

Update gloo submodule #115158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update gloo submodule #115158

wants to merge 1 commit into from

Conversation

pruthvistony
Copy link
Collaborator

@pruthvistony pruthvistony commented Dec 5, 2023 •
edited
Loading

Updates to pull ROCm 6.0 related changes and few minor updates in gloo.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 5, 2023
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 5, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115158

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit e543888 with merge base 58809e8 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pruthvistony pruthvistony added ciflow/trunk Trigger trunk jobs on your pull request rocm priority high priority ROCm PRs from performance or other aspects ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/rocm Trigger "default" config CI on ROCm labels Dec 5, 2023
@pruthvistony
Copy link
Collaborator Author

CI failures doesnt seem to be related to this change.

@malfet ,
Can you please review this PR.

@malfet
Copy link
Contributor

malfet commented Dec 7, 2023

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 5 checks: trunk / macos-12-py3-arm64 / test (default, 3, 3, macos-m1-12), trunk / win-vs2019-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral), trunk / win-vs2019-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral), periodic / macos-12-py3-x86-64 / build, periodic / win-vs2019-cuda11.8-py3 / test (default, 2, 4, windows.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@pruthvistony @dmenig
Update gloo submodule (pytorch#115158)
6ed7be0 
Updates to pull ROCm 6.0 related changes and few minor updates in gloo.

Pull Request resolved: pytorch#115158
Approved by: https://github.com/jeffdaily, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged open source rocm priority high priority ROCm PRs from performance or other aspects topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pruthvistony @malfet @pytorchmergebot @jeffdaily @pytorchbot