[SparseCompressed] Support add(sparse_compressed, dense)
#115432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition involving sparse compressed and dense arguments is implemented requiring that the dense tensor be on the LHS. This change adds support for the other pattern `sparse + dense by permuting arguments. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115432
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b7391fb with merge base 0e63837 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 8, 2023
cpuhrsch
approved these changes
Dec 8, 2023
Addition involving sparse compressed and dense arguments is implemented requiring that the dense tensor be on the LHS. This change adds support for the other pattern `sparse + dense by permuting arguments. [ghstack-poisoned]
Addition involving sparse compressed and dense arguments is implemented requiring that the dense tensor be on the LHS. This change adds support for the other pattern `sparse + dense by permuting arguments. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 22, 2023
`add` when passed one sparse and one dense argument will error if the sparse argument does not have csr layout. This PR modifies the underlying algorithm to be generic on the compressed dimension handling both csr and csc. The functions are renamed to use the `sparse_compressed` qualifier rather than `sparse_csr` Fixes: #114807 Pull Request resolved: #115433 Approved by: https://github.com/cpuhrsch, https://github.com/pearu ghstack dependencies: #115432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
add(sparse_compressed, dense)#115432Addition involving sparse compressed and dense arguments is implemented
requiring that the dense tensor be on the LHS. This change adds support
for the other pattern `sparse + dense by permuting arguments.