-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[export] refactor unflatten.py to be a top-level API #115466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is in preparation for the merging of the internal and external versions of the unflattener. Unflatten needs to be its own API because we are adding more options to it in forthcoming diffs. Differential Revision: [D52001133](https://our.internmc.facebook.com/intern/diff/D52001133/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115466
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit e965048 with merge base 1f3bdf4 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This is in preparation for the merging of the internal and external versions of the unflattener. Unflatten needs to be its own API because we are adding more options to it in forthcoming diffs. Differential Revision: [D52001133](https://our.internmc.facebook.com/intern/diff/D52001133/) [ghstack-poisoned]
This is in preparation for the merging of the internal and external versions of the unflattener. Unflatten needs to be its own API because we are adding more options to it in forthcoming diffs. Differential Revision: [D52001133](https://our.internmc.facebook.com/intern/diff/D52001133/) [ghstack-poisoned]
This is in preparation for the merging of the internal and external versions of the unflattener. Unflatten needs to be its own API because we are adding more options to it in forthcoming diffs. Differential Revision: [D52001133](https://our.internmc.facebook.com/intern/diff/D52001133/) [ghstack-poisoned]
This is in preparation for the merging of the internal and external versions of the unflattener. Unflatten needs to be its own API because we are adding more options to it in forthcoming diffs. Differential Revision: [D52001133](https://our.internmc.facebook.com/intern/diff/D52001133/) [ghstack-poisoned]
This is in preparation for the merging of the internal and external versions of the unflattener. Unflatten needs to be its own API because we are adding more options to it in forthcoming diffs. Differential Revision: [D52001133](https://our.internmc.facebook.com/intern/diff/D52001133/) [ghstack-poisoned]
This is in preparation for the merging of the internal and external versions of the unflattener. Unflatten needs to be its own API because we are adding more options to it in forthcoming diffs. Differential Revision: [D52001133](https://our.internmc.facebook.com/intern/diff/D52001133/) [ghstack-poisoned]
This is in preparation for the merging of the internal and external versions of the unflattener. Unflatten needs to be its own API because we are adding more options to it in forthcoming diffs. Differential Revision: [D52001133](https://our.internmc.facebook.com/intern/diff/D52001133/) [ghstack-poisoned]
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Command
Details for Dev Infra teamRaised by workflow job |
@pytorchbot revert -m="Diff reverted internally" -c="ghfirst" This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).) |
@pytorchbot successfully started a revert job. Check the current status here. |
Can't find any commits resolving PR |
This is in preparation for the merging of the internal and external versions of the unflattener. Unflatten needs to be its own API because we are adding more options to it in forthcoming diffs. Differential Revision: [D52001133](https://our.internmc.facebook.com/intern/diff/D52001133/) cc avikchaudhuri gmagogsfm zhxchen17 tugsbayasgalan angelayi ydwu4 [ghstack-poisoned]
This is in preparation for the merging of the internal and external versions of the unflattener. Unflatten needs to be its own API because we are adding more options to it in forthcoming diffs. Differential Revision: [D52001133](https://our.internmc.facebook.com/intern/diff/D52001133/) cc avikchaudhuri gmagogsfm zhxchen17 tugsbayasgalan angelayi ydwu4 diff-train-skip-merge [ghstack-poisoned]
as title Differential Revision: [D52141387](https://our.internmc.facebook.com/intern/diff/D52141387/) @diff-train-skip-merge Pull Request resolved: #115795 Approved by: https://github.com/zhxchen17 ghstack dependencies: #115466
This is the final divergence between our internal/external unflatteners. Differential Revision: [D52001135](https://our.internmc.facebook.com/intern/diff/D52001135/) @diff-train-skip-merge Pull Request resolved: #115467 Approved by: https://github.com/zhxchen17 ghstack dependencies: #115466, #115795
Stack from ghstack (oldest at bottom):
This is in preparation for the merging of the internal and external versions of
the unflattener. Unflatten needs to be its own API because we are adding more
options to it in forthcoming diffs.
Differential Revision: D52001133
cc @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @ydwu4
@diff-train-skip-merge