Skip to content

Conversation

yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Dec 9, 2023

Copy link

pytorch-bot bot commented Dec 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115477

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ed4ec15 with merge base da341d0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yanboliang yanboliang added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Dec 9, 2023
@yanboliang
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kit1980
Copy link
Contributor

kit1980 commented Dec 9, 2023

What's changed since the revert?

@yanboliang yanboliang deleted the radians branch December 9, 2023 21:15
@yanboliang
Copy link
Contributor Author

@kit1980 No change in this PR. This was reverted at #115126, where there is a bug in the first PR and got fixed now, so we have to reland all others.

@kit1980
Copy link
Contributor

kit1980 commented Dec 10, 2023

No change in this PR. This was reverted at #115126, where there is a bug in the first PR and got fixed now, so we have to reland all others.

Good, and this explanation should probably be in the description.

dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants