-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[2/N] Use std::in_place #115480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2/N] Use std::in_place #115480
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115480
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 71332ca with merge base 937d616 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "topic: not user facing" |
@pytorchbot label "ciflow/binaries" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this header file ever used since it's never included?
I think usages where it is included were removed in a previous PR by @cyyever |
Ok! |
@pytorchbot merge -i |
This PR needs to be approved by an authorized maintainer before merge. |
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, linux.2xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
@pytorchbot merge -f |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot merge -f "Unrelated failure" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@soulitzer This is breaking a large number of contbuilds due to internal usage of |
Use regex to replace 'c10::in_place' with 'std::in_place' should fix them. |
@osalpekar Updated the diff! |
Remove c10/util/in_place.h Pull Request resolved: pytorch#115480 Approved by: https://github.com/soulitzer
Remove c10/util/in_place.h Pull Request resolved: pytorch#115480 Approved by: https://github.com/soulitzer
This reverts commit fcb95bf.
Remove c10/util/in_place.h