Skip to content

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Dec 9, 2023

Remove c10/util/in_place.h

Copy link

pytorch-bot bot commented Dec 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115480

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 71332ca with merge base 937d616 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever
Copy link
Collaborator Author

cyyever commented Dec 9, 2023

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 9, 2023
@cyyever
Copy link
Collaborator Author

cyyever commented Dec 9, 2023

@pytorchbot label "ciflow/binaries"

@pytorch-bot pytorch-bot bot added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Dec 9, 2023
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this header file ever used since it's never included?

@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 13, 2023
@soulitzer soulitzer self-requested a review December 13, 2023 16:18
@soulitzer
Copy link
Contributor

soulitzer commented Dec 13, 2023

I think usages where it is included were removed in a previous PR by @cyyever
There are internal usages however that need to be addressed https://www.internalfb.com/diff/D52123195

@albanD
Copy link
Collaborator

albanD commented Dec 13, 2023

Ok!
I'll let you land both @soulitzer !

@soulitzer
Copy link
Contributor

@pytorchbot merge -i

Copy link

pytorch-bot bot commented Dec 13, 2023

This PR needs to be approved by an authorized maintainer before merge.

@soulitzer
Copy link
Contributor

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 13, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@soulitzer
Copy link
Contributor

@pytorchbot merge -f

Copy link

pytorch-bot bot commented Dec 14, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

@soulitzer
Copy link
Contributor

@pytorchbot merge -f "Unrelated failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the std_inplace2 branch December 14, 2023 13:39
@osalpekar
Copy link
Member

@soulitzer This is breaking a large number of contbuilds due to internal usage of c10::in_place. Can you check them here and forward-fix: D52178758? Either that or we'll need to revert

@cyyever
Copy link
Collaborator Author

cyyever commented Dec 15, 2023

Use regex to replace 'c10::in_place' with 'std::in_place' should fix them.

@soulitzer
Copy link
Contributor

@osalpekar Updated the diff!

guilhermeleobas pushed a commit to guilhermeleobas/pytorch that referenced this pull request Dec 18, 2023
Remove c10/util/in_place.h
Pull Request resolved: pytorch#115480
Approved by: https://github.com/soulitzer
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
Remove c10/util/in_place.h
Pull Request resolved: pytorch#115480
Approved by: https://github.com/soulitzer
michael-sandoval added a commit to michael-sandoval/pytorch that referenced this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants