[export][reland][refactor][2/n] Move tracing logic #115557
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reland of #114768 [ghstack-poisoned]
angelayi
requested review from
albanD,
avikchaudhuri,
gmagogsfm,
tugsbayasgalan and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115557
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c46d19c with merge base 40a14e0 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 11, 2023
Reland of #114768 [ghstack-poisoned]
angelayi
changed the title
Reland of #114768 [ghstack-poisoned]
zhxchen17
approved these changes
Dec 11, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 12, 2023
Reland of #114787 Pull Request resolved: #115558 Approved by: https://github.com/zhxchen17, https://github.com/atalman ghstack dependencies: #115556, #115557
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 12, 2023
Reland of #115271 Fixes #115209 Pull Request resolved: #115559 Approved by: https://github.com/zhxchen17, https://github.com/atalman ghstack dependencies: #115556, #115557, #115558
kwen2501
added a commit
to pytorch/PiPPy
that referenced
this pull request
Dec 14, 2023
## Description pytorch/pytorch#115557 moved `_export_to_torch_ir` to `torch.export._trace`. Limit our torch version in our CI to avoid a break. Since pytorch/pytorch#115557 came after PyTorch 2.2 release cut, PyTorch won't have it till 2.3. So once 2.2 is released, we can switch to release version instead of nightly. Meanwhile, we will be migrating from `_export_to_torch_ir` to `export`. So this version limit is a temporary workaround while we migrate.
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
Reland of pytorch#114768 Pull Request resolved: pytorch#115557 Approved by: https://github.com/zhxchen17 ghstack dependencies: pytorch#115556
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
…#115558) Reland of pytorch#114787 Pull Request resolved: pytorch#115558 Approved by: https://github.com/zhxchen17, https://github.com/atalman ghstack dependencies: pytorch#115556, pytorch#115557
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
Reland of pytorch#115271 Fixes pytorch#115209 Pull Request resolved: pytorch#115559 Approved by: https://github.com/zhxchen17, https://github.com/atalman ghstack dependencies: pytorch#115556, pytorch#115557, pytorch#115558
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Reland of pytorch#114768 Pull Request resolved: pytorch#115557 Approved by: https://github.com/zhxchen17 ghstack dependencies: pytorch#115556
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…#115558) Reland of pytorch#114787 Pull Request resolved: pytorch#115558 Approved by: https://github.com/zhxchen17, https://github.com/atalman ghstack dependencies: pytorch#115556, pytorch#115557
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Reland of pytorch#115271 Fixes pytorch#115209 Pull Request resolved: pytorch#115559 Approved by: https://github.com/zhxchen17, https://github.com/atalman ghstack dependencies: pytorch#115556, pytorch#115557, pytorch#115558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Reland of #114768