Centralize TypeExtendedInterface casts. #11576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9790187 Differential Version: 57609071
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
Differential Revision: D9790187 Differential Version: 57641656
gchanan
approved these changes
Sep 13, 2018
aten/src/ATen/templates/Functions.h
Outdated
| static inline TypeExtendedInterface & infer_type(const Tensor & t) { | ||
| AT_CHECK(t.defined(), "undefined Tensor"); | ||
| return static_cast<TypeExtendedInterface&>(t.type()); | ||
| return getType(t.unsafeGetTensorImpl()); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/Context.cpp
Outdated
| backend, impl->scalar_type(), impl->is_variable()); | ||
| } | ||
|
|
||
| TypeExtendedInterface& getType(const Tensor& impl) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/templates/Functions.h
Outdated
| } | ||
| static inline TypeExtendedInterface & non_specific_type() { | ||
| return static_cast<TypeExtendedInterface&>(at::getNonVariableType(at::Backend::Undefined, at::ScalarType::Float)); | ||
| return getType(tl[0].unsafeGetTensorImpl()); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Differential Revision: D9790187 Differential Version: 57784244
Differential Revision: D9790187 Differential Version: 57805354
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 14, 2018
Summary: Pull Request resolved: pytorch/pytorch#11576 Previously, they were spattered throughout the codebase. We now follow this convention: - LegacyTypeDispatch gives you Type - Context gives you TypeExtendedInterface - Tensor::type() gives you Type - at::getType() gives you TypeExtendedInterface I change some sites to use getType() over type(). Reviewed By: SsnL Differential Revision: D9790187 fbshipit-source-id: 5e2577cb590a5bbf5df530f3763d3b3c0b4625ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11576 Centralize TypeExtendedInterface casts. 💚
:white_circle: #11583 Remove deprecated factory functions from Type. 💚
Previously, they were spattered throughout the codebase.
We now follow this convention:
I change some sites to use getType() over type().
Differential Revision: D9790187