Add Dynamo test expected failure mechanism #115845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that are added to a list in dynamo_test_failures.py will automatically be marked as expectedFailure when run with PYTORCH_TEST_WITH_DYNAMO=1. I'm splitting this PR off on its own so that I can test various things on top of it. Also added an unMarkDynamoStrictTest that is not useful until we turn on strict mode by default. Test Plan: - code reading [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115845
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0d7e656 with merge base 6500cce ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Tests that are added to a list in dynamo_test_failures.py will automatically be marked as expectedFailure when run with PYTORCH_TEST_WITH_DYNAMO=1. I'm splitting this PR off on its own so that I can test various things on top of it. Also added an unMarkDynamoStrictTest that is not useful until we turn on strict mode by default. Test Plan: - code reading [ghstack-poisoned]
This was referenced Dec 14, 2023
voznesenskym
approved these changes
Dec 14, 2023
This was referenced Dec 14, 2023
This was referenced Dec 14, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 15, 2023
In preparation for ~3x increased test time coming in the upcoming PRs. Pull Request resolved: #115855 Approved by: https://github.com/voznesenskym ghstack dependencies: #115845
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 15, 2023
These take too long to run under strict mode. We'll worry about them later. Note that these decorators don't do anything yet (unless we flip the default from non-strict to strict). Pull Request resolved: #115856 Approved by: https://github.com/voznesenskym ghstack dependencies: #115845, #115855
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 15, 2023
Pull Request resolved: #115857 Approved by: https://github.com/voznesenskym ghstack dependencies: #115845, #115855, #115856
This was referenced Dec 15, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 15, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 15, 2023
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
For: test_dispatch.py test_fake_tensor.py test_indexing.py test_linalg.py Pull Request resolved: pytorch#115871 Approved by: https://github.com/voznesenskym ghstack dependencies: pytorch#115845, pytorch#115855, pytorch#115856, pytorch#115857, pytorch#115858, pytorch#115870
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
Featuring: test_mobile_optimizer.py test_module_init.py test_modules.py test_multiprocessing.py test_multiprocessing_spawn.py Pull Request resolved: pytorch#115879 Approved by: https://github.com/voznesenskym ghstack dependencies: pytorch#115845, pytorch#115855, pytorch#115856, pytorch#115857, pytorch#115858, pytorch#115870, pytorch#115871
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
Featuring test_native_mha.py test_nn.py test_prims.py test_schema_check.py test_serialization.py test_show_pickle.py test_sort_and_select.py Pull Request resolved: pytorch#115885 Approved by: https://github.com/voznesenskym ghstack dependencies: pytorch#115845, pytorch#115855, pytorch#115856, pytorch#115857, pytorch#115858, pytorch#115870, pytorch#115871, pytorch#115879
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Tests that are added to a list in dynamo_test_failures.py will automatically be marked as expectedFailure when run with PYTORCH_TEST_WITH_DYNAMO=1. I'm splitting this PR off on its own so that I can test various things on top of it. Also added an unMarkDynamoStrictTest that is not useful until we turn on strict mode by default. Test Plan: - code reading Pull Request resolved: pytorch#115845 Approved by: https://github.com/voznesenskym
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
In preparation for ~3x increased test time coming in the upcoming PRs. Pull Request resolved: pytorch#115855 Approved by: https://github.com/voznesenskym ghstack dependencies: pytorch#115845
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
These take too long to run under strict mode. We'll worry about them later. Note that these decorators don't do anything yet (unless we flip the default from non-strict to strict). Pull Request resolved: pytorch#115856 Approved by: https://github.com/voznesenskym ghstack dependencies: pytorch#115845, pytorch#115855
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Pull Request resolved: pytorch#115857 Approved by: https://github.com/voznesenskym ghstack dependencies: pytorch#115845, pytorch#115855, pytorch#115856
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Pull Request resolved: pytorch#115858 Approved by: https://github.com/voznesenskym ghstack dependencies: pytorch#115845, pytorch#115855, pytorch#115856, pytorch#115857
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Pull Request resolved: pytorch#115870 Approved by: https://github.com/voznesenskym ghstack dependencies: pytorch#115845, pytorch#115855, pytorch#115856, pytorch#115857, pytorch#115858
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
For: test_dispatch.py test_fake_tensor.py test_indexing.py test_linalg.py Pull Request resolved: pytorch#115871 Approved by: https://github.com/voznesenskym ghstack dependencies: pytorch#115845, pytorch#115855, pytorch#115856, pytorch#115857, pytorch#115858, pytorch#115870
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Featuring: test_mobile_optimizer.py test_module_init.py test_modules.py test_multiprocessing.py test_multiprocessing_spawn.py Pull Request resolved: pytorch#115879 Approved by: https://github.com/voznesenskym ghstack dependencies: pytorch#115845, pytorch#115855, pytorch#115856, pytorch#115857, pytorch#115858, pytorch#115870, pytorch#115871
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Featuring test_native_mha.py test_nn.py test_prims.py test_schema_check.py test_serialization.py test_show_pickle.py test_sort_and_select.py Pull Request resolved: pytorch#115885 Approved by: https://github.com/voznesenskym ghstack dependencies: pytorch#115845, pytorch#115855, pytorch#115856, pytorch#115857, pytorch#115858, pytorch#115870, pytorch#115871, pytorch#115879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Tests that are added to a list in dynamo_test_failures.py will
automatically be marked as expectedFailure when run with
PYTORCH_TEST_WITH_DYNAMO=1. I'm splitting this PR off on its own so that
I can test various things on top of it.
Also added an unMarkDynamoStrictTest that is not useful until we turn
on strict mode by default.
Test Plan: