Skip to content

[ROCm] Fix caffe2 build with hipblasv2 api #116073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ROCm] Fix caffe2 build with hipblasv2 api #116073

wants to merge 1 commit into from

Conversation

@xw285cornell
Copy link
Contributor

@xw285cornell xw285cornell commented Dec 19, 2023 •
edited by pytorch-bot bot
Loading

Summary: we need this change along with D52244365 to make caffe2 build happy

Test Plan: OSS CI

Differential Revision: D52275058

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 19, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116073

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 60d5027 with merge base 9a2a444 (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added caffe2 ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch labels Dec 19, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52275058

@github-actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52275058

xw285cornell added a commit to xw285cornell/pytorch that referenced this pull request Dec 19, 2023
@xw285cornell @facebook-github-bot
[ROCm] Fix caffe2 build with hipblasv2 api (pytorch#116073)
d374bba 
Summary:
Pull Request resolved: pytorch#116073

we need this change along with D52244365 to make caffe2 build happy

Test Plan: OSS CI

Differential Revision: D52275058

fbshipit-source-id: 002864a19aa811f52e38ad332502dea97489d780
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52275058

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52275058

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52275058

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 19, 2023
xw285cornell added a commit to xw285cornell/pytorch that referenced this pull request Dec 19, 2023
@xw285cornell @facebook-github-bot
[ROCm] Fix caffe2 build with hipblasv2 api (pytorch#116073)
85eee1e 
Summary:

we need this change along with D52244365 to make caffe2 build happy

Test Plan: OSS CI

Differential Revision: D52275058
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52275058

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52275058

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52275058

xw285cornell added a commit to xw285cornell/pytorch that referenced this pull request Dec 19, 2023
@xw285cornell @facebook-github-bot
[ROCm] Fix caffe2 build with hipblasv2 api (pytorch#116073)
5aa6cce 
Summary:

we need this change along with D52244365 to make caffe2 build happy

Test Plan: OSS CI

Differential Revision: D52275058
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52275058

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52275058

@xw285cornell @facebook-github-bot
[ROCm] Fix caffe2 build with hipblasv2 api (pytorch#116073)
60d5027 
Summary:

we need this change along with D52244365 to make caffe2 build happy

Test Plan: OSS CI

Differential Revision: D52275058
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52275058

@xw285cornell xw285cornell requested a review from malfet December 20, 2023 00:55
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@xw285cornell @dmenig
[ROCm] Fix caffe2 build with hipblasv2 api (pytorch#116073)
483110a 
Summary: we need this change along with D52244365 to make caffe2 build happy

Test Plan: OSS CI

Differential Revision: D52275058

Pull Request resolved: pytorch#116073
Approved by: https://github.com/jeffdaily, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

@malfet malfet malfet approved these changes

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

@fmassa fmassa Awaiting requested review from fmassa

@soumith soumith Awaiting requested review from soumith

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

caffe2 ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: rocm AMD GPU support for Pytorch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xw285cornell @facebook-github-bot @pytorchmergebot @jeffdaily @malfet