Skip to content

Conversation

fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Dec 19, 2023

@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Dec 19, 2023
Copy link

pytorch-bot bot commented Dec 19, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116076

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7c5592d with merge base 4c6e842 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Dec 19, 2023
fduwjj added a commit that referenced this pull request Dec 19, 2023
ghstack-source-id: e61b2a4
Pull Request resolved: #116076
@fduwjj fduwjj requested review from kwen2501 and wconstab December 19, 2023 04:22
cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol wz337 tianyu-l wconstab yf225

[ghstack-poisoned]
fduwjj added a commit that referenced this pull request Dec 27, 2023
ghstack-source-id: 3240127
Pull Request resolved: #116076
Copy link
Contributor

@XilunWu XilunWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Need to make compiler happy by setting a default value to stream id.

cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol wz337 tianyu-l wconstab yf225

[ghstack-poisoned]
fduwjj added a commit that referenced this pull request Dec 29, 2023
ghstack-source-id: 2968922
Pull Request resolved: #116076
@fduwjj
Copy link
Contributor Author

fduwjj commented Dec 29, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 29, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/fduwjj/125/head branch January 1, 2024 15:23
wconstab pushed a commit that referenced this pull request Jan 26, 2024
wconstab pushed a commit that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants