Skip to content

Conversation

mikekgfb
Copy link
Contributor

@mikekgfb mikekgfb commented Dec 23, 2023

Summary: multiply int8/uint8 for AVX512

Test Plan: sandcastle, github

Differential Revision: D52393918

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

Summary: multiply int8/uint8 for AVX512

Test Plan: sandcastle, github

Differential Revision: D52393918
Copy link

pytorch-bot bot commented Dec 23, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116346

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e035c91 with merge base 4f4b931 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52393918

@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Dec 23, 2023
@mikekgfb mikekgfb added the topic: not user facing topic category label Dec 23, 2023
Copy link
Collaborator

@jgong5 jgong5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 25, 2023
@mikekgfb
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Dec 26, 2023

Sorry for jumping in late, but why no unit tests/benchmarks for this one? (Considering that AVX512 can sometimes be slower than AVX2)

@mikekgfb
Copy link
Contributor Author

mikekgfb commented Dec 27, 2023

Sorry for jumping in late, but why no unit tests/benchmarks for this one? (Considering that AVX512 can sometimes be slower than AVX2)

This is for users that already have picked AVX512 - if they don't, they end up in AVX2 land (upgrade as separate PR n#116235.

I started writing unit tests, but found that we already have pre-existing unit tests for testing the various operations in vec.h and it's derived children. @malfet , please also check out additional discussion about Aten testing in fbcode on the internal diff.

@facebook-github-bot facebook-github-bot deleted the export-D52393918 branch December 30, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: cpu CPU specific problem (e.g., perf, algorithm) topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants