Skip to content

Some basic support for uint{16,32,64} codegen in CPU inductor #116810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Some basic support for uint{16,32,64} codegen in CPU inductor #116810

wants to merge 8 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Jan 5, 2024 •
edited by pytorch-bot bot
Loading

@ezyang
Some basic support for uint{16,32,64} codegen in CPU inductor
cfa5977 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116810

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4bdf285 with merge base 6ebb26d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jan 5, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
ezyang added a commit that referenced this pull request Jan 5, 2024
@ezyang
Some basic support for uint{16,32,64} codegen in CPU inductor
4e0b1fa 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: b2bb0a8
Pull Request resolved: #116810
@ezyang
Update on "Some basic support for uint{16,32,64} codegen in CPU induc…
a1b4c24 
…tor"

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jan 5, 2024
@ezyang
Some basic support for uint{16,32,64} codegen in CPU inductor
d1b06f3 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 2ffb299
Pull Request resolved: #116810
@ezyang
Update on "Some basic support for uint{16,32,64} codegen in CPU induc…
043ef2f 
…tor"

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jan 8, 2024
@ezyang
Some basic support for uint{16,32,64} codegen in CPU inductor
c474995 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 5b30d17
Pull Request resolved: #116810
@ezyang
Update on "Some basic support for uint{16,32,64} codegen in CPU induc…
ee172ff 
…tor"

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jan 9, 2024
@ezyang
Some basic support for uint{16,32,64} codegen in CPU inductor
4a593a8 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: af815f1
Pull Request resolved: #116810
@ezyang
Update on "Some basic support for uint{16,32,64} codegen in CPU induc…
ac22734 
…tor"

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Jan 10, 2024
Closed
ezyang added 3 commits January 10, 2024 13:34
@ezyang
Update on "Some basic support for uint{16,32,64} codegen in CPU induc…
7a4657d 
…tor"

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
@ezyang
Update on "Some basic support for uint{16,32,64} codegen in CPU induc…
6ec3772 
…tor"

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
@ezyang
Update on "Some basic support for uint{16,32,64} codegen in CPU induc…
4bdf285 
…tor"

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
chenyang78
chenyang78 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@chenyang78 chenyang78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

kadeng
kadeng reviewed Jan 12, 2024
View reviewed changes
torch/_inductor/codegen/cpp.py
torch.int32: "int",
torch.int16: "short",
torch.int8: "signed char",
torch.uint64: "unsigned long",
Copy link
Contributor

@kadeng kadeng Jan 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but as far as I know, while in practice (on 64-bit systems) these types have the right bit-size, this is not guaranteed by the standard. Maybe it's better to use C++11 fixed width integer types? ( https://en.cppreference.com/w/cpp/types/integer ).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't know why the other usages here weren't using the fixed width types lol

@ezyang
Copy link
Contributor Author

ezyang commented Jan 12, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 12, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Jan 12, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2488/head branch January 16, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyang78 chenyang78 chenyang78 approved these changes

@desertfire desertfire desertfire approved these changes

@eellison eellison eellison approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

+1 more reviewer

@kadeng kadeng kadeng left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: inductor topic: new features topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ezyang @pytorchmergebot @kadeng @chenyang78 @desertfire @eellison