[pt-vulkan][ez] Replace c10::overflows with native equivalent
#117180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context This change is part of a set of changes that removes all references to the `c10` library in the `api/`, `graph/`, and `impl/` folders of the PyTorch Vulkan codebase. This is to ensure that these components can be built as a standalone library such that they can be used as the foundations of a Android GPU delegate for ExecuTorch. ## Notes for Reviewers This changeset is very straightforward, as it simply copies the required components of `c10::overflows` from [`c10/util/Half.h`](https://github.com/pytorch/pytorch/blob/main/c10/util/Half.h#L477) into `api/Utils.h`. Differential Revision: [D52662236](https://our.internmc.facebook.com/intern/diff/D52662236/) [ghstack-poisoned]
pytorch-bot
bot
added
ciflow/periodic
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117180
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 5893d13 with merge base 94363ce ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jan 10, 2024
[pt-vulkan][ez] Replace
ska::flat_hash_map, c10::get_hash with std::unordered_map, std::hash
#117177
Closed
…alent" ## Context This change is part of a set of changes that removes all references to the `c10` library in the `api/`, `graph/`, and `impl/` folders of the PyTorch Vulkan codebase. This is to ensure that these components can be built as a standalone library such that they can be used as the foundations of a Android GPU delegate for ExecuTorch. ## Notes for Reviewers This changeset is very straightforward, as it simply copies the required components of `c10::overflows` from [`c10/util/Half.h`](https://github.com/pytorch/pytorch/blob/main/c10/util/Half.h#L477) into `api/Utils.h`. Differential Revision: [D52662236](https://our.internmc.facebook.com/intern/diff/D52662236/) [ghstack-poisoned]
yipjustin
approved these changes
Jan 11, 2024
…alent" ## Context This change is part of a set of changes that removes all references to the `c10` library in the `api/`, `graph/`, and `impl/` folders of the PyTorch Vulkan codebase. This is to ensure that these components can be built as a standalone library such that they can be used as the foundations of a Android GPU delegate for ExecuTorch. ## Notes for Reviewers This changeset is very straightforward, as it simply copies the required components of `c10::overflows` from [`c10/util/Half.h`](https://github.com/pytorch/pytorch/blob/main/c10/util/Half.h#L477) into `api/Utils.h`. Differential Revision: [D52662236](https://our.internmc.facebook.com/intern/diff/D52662236/) [ghstack-poisoned]
…alent" ## Context This change is part of a set of changes that removes all references to the `c10` library in the `api/`, `graph/`, and `impl/` folders of the PyTorch Vulkan codebase. This is to ensure that these components can be built as a standalone library such that they can be used as the foundations of a Android GPU delegate for ExecuTorch. ## Notes for Reviewers This changeset is very straightforward, as it simply copies the required components of `c10::overflows` from [`c10/util/Half.h`](https://github.com/pytorch/pytorch/blob/main/c10/util/Half.h#L477) into `api/Utils.h`. Differential Revision: [D52662236](https://our.internmc.facebook.com/intern/diff/D52662236/) [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 11, 2024
## Context This change is part of a set of changes that removes all references to the `c10` library in the `api/`, `graph/`, and `impl/` folders of the PyTorch Vulkan codebase. This is to ensure that these components can be built as a standalone library such that they can be used as the foundations of a Android GPU delegate for ExecuTorch. ## Notes for Reviewers This changeset introduces `api::ScalarType` in `api/Types.h`, which is intended to function the same as `c10::ScalarType`; thus `api/Types.h` is the primary file of interest. The rest of the changes are straightforward replacements of `c10::ScalarType` with `api::ScalarType`. Differential Revision: [D52662237](https://our.internmc.facebook.com/intern/diff/D52662237/) Pull Request resolved: #117181 Approved by: https://github.com/yipjustin ghstack dependencies: #117176, #117177, #117178, #117179, #117180
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 11, 2024
…der (#117183) ## Context This change is part of a set of changes that removes all references to the `c10` library in the `api/`, `graph/`, and `impl/` folders of the PyTorch Vulkan codebase. This is to ensure that these components can be built as a standalone library such that they can be used as the foundations of a Android GPU delegate for ExecuTorch. ## Notes for Reviewers This changeset removes references to `c10::MemoryFormat` in `api/Tensor.[h,cpp]`; when constructing a `vTensor`, the `api::StorageType` (i.e. whether the tensor will be backed by buffer or texture storage) and `api::GPUMemoryLayout` (i.e. which dimension will be the fastest moving dimension) must be specified directly. Differential Revision: [D52662234](https://our.internmc.facebook.com/intern/diff/D52662234/) Pull Request resolved: #117183 Approved by: https://github.com/liuk22, https://github.com/yipjustin ghstack dependencies: #117176, #117177, #117178, #117179, #117180, #117181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
api/folder #117183c10::ScalarTypewith native equivalent #117181c10::overflowswith native equivalent #117180ArrayRefwithstd::vector<T>𜦻TORCH_CHECKand similar macros with native equivalents #117178ska::flat_hash_map,c10::get_hashwithstd::unordered_map,std::hash#117177c10::irange,C10_LIKELY,c10::SmallVector, etc.) #117176Context
This change is part of a set of changes that removes all references to the
c10library in theapi/,graph/, andimpl/folders of the PyTorch Vulkan codebase. This is to ensure that these components can be built as a standalone library such that they can be used as the foundations of a Android GPU delegate for ExecuTorch.Notes for Reviewers
This changeset is very straightforward, as it simply copies the required components of
c10::overflowsfromc10/util/Half.hintoapi/Utils.h.Differential Revision: D52662236