Change dynamo_test_failures.py to silently run skipped tests #117401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. [ghstack-poisoned]
This was referenced Jan 12, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117401
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 838d22c with merge base 28bb31e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jan 12, 2024
voznesenskym
approved these changes
Jan 12, 2024
zou3519
added
the
keep-going
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Jan 12, 2024
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. ghstack-source-id: ae07805 Pull Request resolved: #117401
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. [ghstack-poisoned]
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. [ghstack-poisoned]
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. [ghstack-poisoned]
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Jan 16, 2024
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. ghstack-source-id: 4c42625 Pull Request resolved: #117401
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. [ghstack-poisoned]
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. [ghstack-poisoned]
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. [ghstack-poisoned]
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Jan 17, 2024
- We silently run skipped tests and then raise a skip message with the error message (if any) - Instead of raising expectedFailure, we raise a skip message with the error message (if any) We log the skip messages in CI, so this will let us read the logs and do some basic triaging of the failure messages. Test Plan: - existing tests. I hope that there are no tests that cause each other to fail. ghstack-source-id: 6b69fd8 Pull Request resolved: #117401
|
@pytorchbot merge -f "dynamo shard passed" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
error message (if any)
error message (if any)
We log the skip messages in CI, so this will let us read the logs and do
some basic triaging of the failure messages.
Test Plan:
to fail.