Skip to content

[CI] Skip lib for xpu binary unit test #117514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[CI] Skip lib for xpu binary unit test #117514

wants to merge 2 commits into from

Conversation

chuanqi129
Copy link
Collaborator

@chuanqi129 chuanqi129 commented Jan 16, 2024 •
edited
Loading

Skip .so and .a libraries under build/bin/ for test_xpu_bin in CI

Works for #114850 also

@chuanqi129 chuanqi129 requested a review from a team as a code owner January 16, 2024 03:05
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117514

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a3bcf16 with merge base ae3d709 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@chuanqi129 chuanqi129 requested a review from EikanWang January 16, 2024 03:05
@chuanqi129 chuanqi129 added ciflow/xpu Run XPU CI tasks topic: not user facing topic category labels Jan 16, 2024
@chuanqi129 chuanqi129 requested review from atalman and huydhn January 16, 2024 03:07
malfet
malfet approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not, but what is "UT"?

malfet
malfet reviewed Jan 16, 2024
View reviewed changes
@chuanqi129 chuanqi129 changed the title [CI] Skip lib for xpu binary UT test [CI] Skip lib for xpu binary unit test Jan 16, 2024
@chuanqi129
Copy link
Collaborator Author

Sure, why not, but what is "UT"?

Thanks @malfet for the review. Renamed the PR.

@chuanqi129 @malfet
Update .ci/pytorch/test.sh
a3bcf16 
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
@chuanqi129 chuanqi129 force-pushed the chuanqiw/skip_lib_for_xpu_ci branch from 4db4275 to a3bcf16 Compare January 16, 2024 06:02
@chuanqi129
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 16, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@EikanWang EikanWang Awaiting requested review from EikanWang

@atalman atalman Awaiting requested review from atalman

@huydhn huydhn Awaiting requested review from huydhn

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source topic: not user facing topic category

Projects

PyTorch Intel
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chuanqi129 @pytorchmergebot @malfet @pytorchbot