Skip to content

use getPinnedMemoryAllocator for privateuseone #117530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

use getPinnedMemoryAllocator for privateuseone #117530

wants to merge 2 commits into from

Conversation

garfield1997
Copy link
Contributor

Fixes #117482

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117530

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 619dfb2 with merge base dd2cff1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@garfield1997 garfield1997 mentioned this pull request Jan 16, 2024
Closed
ezyang
ezyang approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment referencing #14560 and, if you have time, send us a follow up PR for that issue.

@ezyang
Copy link
Contributor

ezyang commented Jan 16, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 16, 2024
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 16, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@garfield1997
Copy link
Contributor Author

I'm not sure which label this change belongs to. Could you please help me determine that? @ezyang

@ezyang ezyang added the topic: not user facing topic category label Jan 17, 2024
@ezyang
Copy link
Contributor

ezyang commented Jan 17, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use getPinnedMemoryAllocator for privateuseone

4 participants

@garfield1997 @ezyang @pytorchmergebot @pytorchbot