-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[dynamo] Add hasattr support for TupleVariable #117694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117694
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (6 Unrelated Failures)As of commit e555fb5 with merge base 84cfe6d ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D52850665 |
Summary: This change adds support hasattr support for TupleVariable in dynamo. This fix is part of: pytorch#117670 Test Plan: Unit test and CI Differential Revision: D52850665
fa98125
to
e555fb5
Compare
This pull request was exported from Phabricator. Differential Revision: D52850665 |
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Is this fix finished? I still got torch._dynamo.exc.Unsupported: hasattr: TupleVariable() error when using dynamo export to export opt-125m model under gptq quantization algorithm. |
Summary:
This change adds support hasattr support for TupleVariable in dynamo.
This fix is part of: #117670
Test Plan: Unit test and CI
Differential Revision: D52850665
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng